223181 - [META] Bookmark rewrite cleanup

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[David Haas (gone, not reading mail)]

I'm attaching various fixes I already have for the bookmark system here. 
They'll come as one big (well, not that big) patch - it should be easy to split
into bite sized morsels if that's preferred.

Comment 1

[David Haas (gone, not reading mail)]

Attachment: Export HTML/Plist patch

This patch a) fixes the HTML export system (which is broken on 10.2, and won't
even run on 10.1) and b) adds in support for exporting Safari.plist files. 
Beyond the new -writeSafariDictionary methods, I moved all the declarations for
export/import keys into BookmarkItem.h and defined them in BookmarkItem.m.

Comment 2

[David Haas (gone, not reading mail)]

Attachment: Startup cleanup

This patch fixes a boo-boo on files which didn't have the toolbar flag set
properly, and schmears out loading the site icons so there isn't such a delay
on load.

Comment 3

[David Haas (gone, not reading mail)]

Attachment: Bookmark Toolbar patch

This a) fixes a crash which can occur if a bookmark folder in the toolbar is
accidentally dropped into itself on a drag & drop
b) Makes sure the toolbar is visible on the first window if Camino was launched
to handle an apple-event
c) Preserves the order of bookmarks in a folder in the event of a mass drag &
drop (current behavior reverses their order).

Comment 4

[David Haas (gone, not reading mail)]

Attachment: Bookmark Info Window patch

This prevents titles of bookmark from overlapping the "close/minimize/maximize"
buttons on the Bookmark Info panel.

Comment 5

[David Haas (gone, not reading mail)]

Attachment: BookmarkView patch

This 
a)makes sure the bookmarks are visible in the event Camino was launched via an
apple-event
b)pops open the search result window when you do a search, in the event it was
hidden
c)preserves the order of bookmarks dropped in a mass drag & drop (current
behavior reverses their order in a folder)
d)fixes some button states appropriately depending on what folder is selected
e)gets rid of a useless method & cleans up a differnt method.

Comment 6

[David Haas (gone, not reading mail)]

Attachment: Bookmark Icon patch

This preserves the top 10 list, toolbar bar, etc icons in the event you change
the dock menu folder.

Comment 7

[David Haas (gone, not reading mail)]

cc sbwoodside, pushing pinkerton's e-mails from this bug today into the triple
digets ;)

Comment 8

[S Woodside]

Personally, I'd rather see a separate bug for each one. Just easier to keep
track of (but maybe not to anyone else)

Comment 9

[Ludovic Hirlimann [:Usul]]

I agree with simon. I will split the bug and patches and make this one a META,
with all bugs created from this one in the dependency tree.

Comment 10

[Ludovic Hirlimann [:Usul]]

nominee for 0.8

Comment 11

[S Woodside]

Which of these fixes the "add separator" button not moving?

Comment 12

[David Haas (gone, not reading mail)]

re comment 11: bug 223413.  It's just a replacement nib.  

Comment 13

[Prachi Gauriar]

Removing dependency on bug 223576.  How that's related to this bug in any way is
beyond me.

Comment 14

[S Woodside]

Comment on attachment 133819 [details] [diff] [review]
Bookmark Icon patch

unset review requests since this is a meta bug now.

Comment 15

[Jasper]

I added dependancy on bug 224629.

Comment 16

[Warren TenBrook]

Nominating bug 199790

Comment 17

[Josh Aas]

Removing bug 225276 from the list since it has nothing to do with bookmarks.

Comment 18

[Mike Pinkerton (not reading bugmail)]

removing things we know aren't related to the bm cleanup and closing, since
we're tracking the bugs individually now.