223560 - clean up the ldap server migration code

Status: RESOLVED FIXED

(MailNews Core :: Profile Migration, defect)

Description

[Scott MacGregor]

clean up the ldap server migration code

right now, I think we try to migrate from the pref UI and the compose window.

we should move the migration code to messenger migrator, and call it on normal
profile migration.

we could continue to call this code from the compose window or from the ab UI
(for profiles already migrated from earlier versions) by using a "have we
migrated the ldap settings" pref and check it from within the messenger migrator
service.

code clean up / future.

Comment 1

[David :Bienvenu]

taking, I have a fix.

Comment 2

[David :Bienvenu]

Attachment: proposed fix

Comment 3

[David :Bienvenu]

Attachment: whoops, forgot the makefile change

Comment 4

[Scott MacGregor]

adding to the tracking list

Comment 5

[David :Bienvenu]

Comment on attachment 134063 [details] [diff] [review]
whoops, forgot the makefile change

I'd like to check this into 1.6a, so it will make tbird .4

Comment 6

[David :Bienvenu]

fix checked in, r/a=sspitzer over aim

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 134063 [details] [diff] [review]
whoops, forgot the makefile change

>Index: base/src/nsMessengerMigrator.cpp

This change broke building with --disable-ldap .

Comment 8

[David :Bienvenu]

Attachment: fix building with disable ldap

Comment 9

[David :Bienvenu]

sorry about that - this should fix that. I'll check it in once I get approval.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 134250 [details] [diff] [review]
fix building with disable ldap

r/sr/a=sspitzer for 1.6a

Comment 11

[Scott MacGregor]

this bug fix broke ldap for me. Try to add a new ldap directory via prefs. Note
the JS errors about QueryInterace failing. We don't list the ldap server in the
prefs panel.

Bring up a compose window and note the JS error about QueryInterface failing. 

Patch coming up. 

Comment 12

[Scott MacGregor]

Attachment: fix QueryInterface for the ldap prefs service

Comment 13

[Scott MacGregor]

*** Bug 224407 has been marked as a duplicate of this bug. ***

Comment 14

[David :Bienvenu]

Attachment: more fixes for migration

these are from a cvs m2 tbird enterprise branch - these fix it so that ldap
servers are migrated correctly w/o a relaunch, and work correctly. This also
fixes  local folder migration so that the folders show up w/o a relaunch as
well.

Comment 15

[Scott MacGregor]

Comment on attachment 135207 [details] [diff] [review]
more fixes for migration

plussing for the trunk if this fix isn't in the trunk already.