227265 - View/Character Encoding changes state of outgoing message, so does not belong into "View".

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Andreas Krüger]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031107 Debian/1.5-3
Build Identifier: Mozilla Thunderbird 0.3 (20031105) from Debian/unstable

The way to customize the character encoding of an outgoing message goes through
View/Character Coding.

As I actually change what gets send, I don't think it is appropriate there.
It's also not where I'm looking for it.

I suggest this should be moved to the "Options" menu.

(Also, I'd personally prefer the more precise name "Character Encoding",
as that's what the MIME standard calls it.)


Ok, let me go through the stuff the bug form asks me to fill out:

Reproducible: Always

Steps to Reproduce:

Steps to reproduce:

1. Compose a message.
   Possibly with special characters such as German Umlauts ִײ�הצ��
   or the Euro-character €.
2. Before sending it, change the character encoding. Try ISO-8859-15 or UTF-8.
3. How did you go about doing 2. ?

Actual Results:  
What happens?

You need to change the character encoding through the "View" menu.


Expected Results:  
What should have happened?

When I do anything in the "View" menu, that should only change things on my
side of the wire.  Whatever I do there should never be detectable by whoever
gets the mail.  Of course, a character encoding is quite detectable by whoever
gets the mail I compose, and it may even determine whether or not that person
is able to even read it.

Comment 1

[Prognathous]

Please change Hardware and OS to All.

Prog.

Comment 2

[Andreas Krüger]

Prog, thanks for pointing that out.  I did.

Comment 3

[Jungshik Shin]

'Character Coding' was replaced by 'Character Encoding' recently. 

As for the location of 'character encoding', it's certainly not intuitive. We
have to move it somewhere else, but I can't come up with a clear-cut winner. 

Comment 4

[Prognathous]

Updating summary: "Coding" -> "Encoding". See comment #3

Prog.

Comment 5

[Andreas Krüger]

> We have to move it somewhere else, but I can't come up with a clear-cut winner.

How 'bout the "Options" toplevel menue of the Compose window?

Comment 6

[Andreas Krüger]

It may be worth it to provide the functionality under the same GUI-umbrella,
for this bug, for bug 229462 and for bug 216132.

In each of these bugs, the issue is an instance of
"change global state for only one message being currently composed".

Comment 7

[Jungshik Shin]

Attachment: patch for mozilla suite

I moved 'Character Encoding' menu to 'Options' from 'View'
I'll upload a patch for thunderbird later.

Comment 8

[Mike Cowperthwaite]

(In reply to comment #7)
> Created an attachment (id=155605)
> patch for mozilla suite
> 
> I moved 'Character Encoding' menu to 'Options' from 'View'

FYI: The Mozilla bug for this change is bug 92499.

Comment 9

[Jungshik Shin]

Attachment: patch for tb

patch for bug 92499 shares a part with this patch (accesskey change)

Comment 10

[Jungshik Shin]

Comment on attachment 158611 [details] [diff] [review]
patch for tb

asking for r/sr. If it's all right to make a  change affecting L10N now,  this
should go in for aviary-1.0 branch as well.

Comment 11

[[e-mail]]

Comment on attachment 158611 [details] [diff] [review]
patch for tb

>         <menupopup id="optionsMenuPopup"> 
>+          <menu id = "maileditCharsetMenu" />
I wouldn't have thought that the first position in this menu would be the
appropriate place for this menuitem. Also, you could compress the whitespace,
only the space between menu and id is necessary.

> <!ENTITY selectAddressCmd.label "Select Addresses...">
> <!ENTITY selectAddressCmd.key "">
>-<!ENTITY selectAddressCmd.accesskey "c">
>+<!ENTITY selectAddressCmd.accesskey "a">
Should be capital A to match the label (access key best practice is either
match case or upper case).

Comment 12

[Jungshik Shin]

Thank you for your comments. Do you have any suggestion as to where to put it in
Options? I realized 
that ordinary users wouldn't change it often. 

BTW, does the case matter in access key? I'm gonna change 'a' to 'A' as you
suggested, but I'm just 
wondering because on Linux, I can't make a distinction between two access keys
that differ only in cases. 

Comment 13

[Stefan Borggraefe]

(In reply to comment #12)
> Thank you for your comments. Do you have any suggestion as to where to put it in
> Options?

IMHO this belongs to the menuitem group

Return Receipt
Priority
Send a Copy To

because all of these settings are for "static options" for the message you are
composing. The menu items above these are for invoking "actions". I would say
move the menu between Priority and Send a Copy To.

> BTW, does the case matter in access key?

Yes, see http://www.mozilla.org/access/keyboard/accesskey.

> I'm gonna change 'a' to 'A' as you
> suggested, but I'm just 
> wondering because on Linux, I can't make a distinction between two access keys
> that differ only in cases. 

In this case it will only save a few CPU cycles, because the string won't be
scanned twice.

Comment 14

[Jungshik Shin]

Comment on attachment 158611 [details] [diff] [review]
patch for tb

I've uploaded a new patch to bug 92499 (that covers both TB and suite). Let's
just deal with this issue there.

Comment 15

[Jungshik Shin]

Attachment: real patch for TB

mail/components/compose/content/compose.xul seems to be a dummy. shouldn't we
get rid of it? Is it used anywhere? 

Anyway, it's mail/components/compose/content/messengercompose.xul that needs to
be patched. This patch is independent of the Mozilla-mail patch.

Comment 16

[Jungshik Shin]

Attachment: screenshot with attachment 158699

Comment 17

[Prognathous]

jshin, wouldn't it be better to keep consistency with the main Character
Encoding menu by renaming "Customize..." to "Customize List..."? See Bug 52157
for this fairly recent change in Aviary and Seamonkey.

Prog.

Comment 18

[Jungshik Shin]

(In reply to comment #17)
> jshin, wouldn't it be better to keep consistency with the main Character
> Encoding menu by renaming "Customize..." to "Customize List..."? See Bug 52157
> for this fairly recent change in Aviary and Seamonkey.

Thanks for the reminder. However, that's orthogonal to this bug. Actually, that
problem should have been taken care of in bug 52157. I'll file a new bug on this. 

Comment 19

[Scott MacGregor]

Comment on attachment 158699 [details] [diff] [review]
real patch for TB 

I can plus this instead of bothering Neil who already reviewed the seamonkey
version of this patch.

Comment 20

[Jungshik Shin]

Comment on attachment 158699 [details] [diff] [review]
real patch for TB 

thansk for r/sr.
asking for aviary-1.0 approval.

Comment 21

[Asa Dotzler [:asa]]

Comment on attachment 158699 [details] [diff] [review]
real patch for TB 

a=asa for aviary checkin.

Comment 22

[Mike Cowperthwaite]

Verified fixed in TB version 0.8+ (20041029), Win2K.  Thanks, Jungshik!