Closed
Bug 227265
Opened 21 years ago
Closed 20 years ago
View/Character Encoding changes state of outgoing message, so does not belong into "View".
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
VERIFIED
FIXED
Thunderbird0.9
People
(Reporter: andreas.krueger, Assigned: jshin1987)
References
(Blocks 1 open bug)
Details
(Keywords: fixed-aviary1.0)
Attachments
(2 files, 2 obsolete files)
4.56 KB,
patch
|
mscott
:
review+
Bienvenu
:
superreview+
asa
:
approval-aviary+
|
Details | Diff | Splinter Review |
37.93 KB,
image/jpeg
|
Details |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5) Gecko/20031107 Debian/1.5-3 Build Identifier: Mozilla Thunderbird 0.3 (20031105) from Debian/unstable The way to customize the character encoding of an outgoing message goes through View/Character Coding. As I actually change what gets send, I don't think it is appropriate there. It's also not where I'm looking for it. I suggest this should be moved to the "Options" menu. (Also, I'd personally prefer the more precise name "Character Encoding", as that's what the MIME standard calls it.) Ok, let me go through the stuff the bug form asks me to fill out: Reproducible: Always Steps to Reproduce: Steps to reproduce: 1. Compose a message. Possibly with special characters such as German Umlauts ִײ�הצ�� or the Euro-character €. 2. Before sending it, change the character encoding. Try ISO-8859-15 or UTF-8. 3. How did you go about doing 2. ? Actual Results: What happens? You need to change the character encoding through the "View" menu. Expected Results: What should have happened? When I do anything in the "View" menu, that should only change things on my side of the wire. Whatever I do there should never be detectable by whoever gets the mail. Of course, a character encoding is quite detectable by whoever gets the mail I compose, and it may even determine whether or not that person is able to even read it.
Comment 1•21 years ago
|
||
Please change Hardware and OS to All. Prog.
Reporter | ||
Comment 2•21 years ago
|
||
Prog, thanks for pointing that out. I did.
OS: Linux → All
Hardware: PC → All
Assignee | ||
Comment 3•20 years ago
|
||
'Character Coding' was replaced by 'Character Encoding' recently. As for the location of 'character encoding', it's certainly not intuitive. We have to move it somewhere else, but I can't come up with a clear-cut winner.
Comment 4•20 years ago
|
||
Updating summary: "Coding" -> "Encoding". See comment #3 Prog.
Summary: View/Character Coding changes state of outgoing message, so does not belong into "View". → View/Character Encoding changes state of outgoing message, so does not belong into "View".
Reporter | ||
Comment 5•20 years ago
|
||
> We have to move it somewhere else, but I can't come up with a clear-cut winner.
How 'bout the "Options" toplevel menue of the Compose window?
Reporter | ||
Comment 6•20 years ago
|
||
It may be worth it to provide the functionality under the same GUI-umbrella, for this bug, for bug 229462 and for bug 216132. In each of these bugs, the issue is an instance of "change global state for only one message being currently composed".
Assignee | ||
Comment 7•20 years ago
|
||
I moved 'Character Encoding' menu to 'Options' from 'View' I'll upload a patch for thunderbird later.
Assignee: mscott → jshin
Status: NEW → ASSIGNED
Comment 8•20 years ago
|
||
(In reply to comment #7) > Created an attachment (id=155605) > patch for mozilla suite > > I moved 'Character Encoding' menu to 'Options' from 'View' FYI: The Mozilla bug for this change is bug 92499.
Assignee | ||
Comment 9•20 years ago
|
||
patch for bug 92499 shares a part with this patch (accesskey change)
Assignee | ||
Comment 10•20 years ago
|
||
Comment on attachment 158611 [details] [diff] [review] patch for tb asking for r/sr. If it's all right to make a change affecting L10N now, this should go in for aviary-1.0 branch as well.
Attachment #158611 -
Flags: superreview?(mscott)
Attachment #158611 -
Flags: review?(neil.parkwaycc.co.uk)
Comment 11•20 years ago
|
||
Comment on attachment 158611 [details] [diff] [review] patch for tb > <menupopup id="optionsMenuPopup"> >+ <menu id = "maileditCharsetMenu" /> I wouldn't have thought that the first position in this menu would be the appropriate place for this menuitem. Also, you could compress the whitespace, only the space between menu and id is necessary. > <!ENTITY selectAddressCmd.label "Select Addresses..."> > <!ENTITY selectAddressCmd.key ""> >-<!ENTITY selectAddressCmd.accesskey "c"> >+<!ENTITY selectAddressCmd.accesskey "a"> Should be capital A to match the label (access key best practice is either match case or upper case).
Assignee | ||
Comment 12•20 years ago
|
||
Thank you for your comments. Do you have any suggestion as to where to put it in Options? I realized that ordinary users wouldn't change it often. BTW, does the case matter in access key? I'm gonna change 'a' to 'A' as you suggested, but I'm just wondering because on Linux, I can't make a distinction between two access keys that differ only in cases.
Target Milestone: --- → Thunderbird0.9
Comment 13•20 years ago
|
||
(In reply to comment #12) > Thank you for your comments. Do you have any suggestion as to where to put it in > Options? IMHO this belongs to the menuitem group Return Receipt Priority Send a Copy To because all of these settings are for "static options" for the message you are composing. The menu items above these are for invoking "actions". I would say move the menu between Priority and Send a Copy To. > BTW, does the case matter in access key? Yes, see http://www.mozilla.org/access/keyboard/accesskey. > I'm gonna change 'a' to 'A' as you > suggested, but I'm just > wondering because on Linux, I can't make a distinction between two access keys > that differ only in cases. In this case it will only save a few CPU cycles, because the string won't be scanned twice.
Assignee | ||
Updated•20 years ago
|
Attachment #155605 -
Attachment is obsolete: true
Assignee | ||
Comment 14•20 years ago
|
||
Comment on attachment 158611 [details] [diff] [review] patch for tb I've uploaded a new patch to bug 92499 (that covers both TB and suite). Let's just deal with this issue there.
Attachment #158611 -
Attachment is obsolete: true
Attachment #158611 -
Flags: superreview?(mscott)
Attachment #158611 -
Flags: review?(neil.parkwaycc.co.uk)
Assignee | ||
Comment 15•20 years ago
|
||
mail/components/compose/content/compose.xul seems to be a dummy. shouldn't we get rid of it? Is it used anywhere? Anyway, it's mail/components/compose/content/messengercompose.xul that needs to be patched. This patch is independent of the Mozilla-mail patch.
Assignee | ||
Comment 16•20 years ago
|
||
Comment 17•20 years ago
|
||
jshin, wouldn't it be better to keep consistency with the main Character Encoding menu by renaming "Customize..." to "Customize List..."? See Bug 52157 for this fairly recent change in Aviary and Seamonkey. Prog.
Assignee | ||
Comment 18•20 years ago
|
||
(In reply to comment #17) > jshin, wouldn't it be better to keep consistency with the main Character > Encoding menu by renaming "Customize..." to "Customize List..."? See Bug 52157 > for this fairly recent change in Aviary and Seamonkey. Thanks for the reminder. However, that's orthogonal to this bug. Actually, that problem should have been taken care of in bug 52157. I'll file a new bug on this.
Assignee | ||
Updated•20 years ago
|
Attachment #158699 -
Flags: superreview?(bienvenu)
Attachment #158699 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•20 years ago
|
Attachment #158699 -
Flags: superreview?(bienvenu) → superreview+
Comment 19•20 years ago
|
||
Comment on attachment 158699 [details] [diff] [review] real patch for TB I can plus this instead of bothering Neil who already reviewed the seamonkey version of this patch.
Attachment #158699 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Comment 20•20 years ago
|
||
Comment on attachment 158699 [details] [diff] [review] real patch for TB thansk for r/sr. asking for aviary-1.0 approval.
Attachment #158699 -
Flags: approval-aviary?
Assignee | ||
Updated•20 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 21•20 years ago
|
||
Comment on attachment 158699 [details] [diff] [review] real patch for TB a=asa for aviary checkin.
Attachment #158699 -
Flags: approval-aviary? → approval-aviary+
Assignee | ||
Updated•20 years ago
|
Whiteboard: fixed-aviary1.0
Comment 22•20 years ago
|
||
Verified fixed in TB version 0.8+ (20041029), Win2K. Thanks, Jungshik!
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Keywords: fixed-aviary1.0
Whiteboard: fixed-aviary1.0
You need to log in
before you can comment on or make changes to this bug.
Description
•