228620 - Add AskJeeves search to build

Status: VERIFIED FIXED

(SeaMonkey :: Search, enhancement)

Description

[Andreas Kunz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031209
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6b) Gecko/20031209

This was already done in the first patch of bug 225490, but incompletely. I was
asked to file a new bug and post a patch. Patch coming.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Andreas Kunz]

Bug 94651 needs to be fixed so AskJeeves result links in the sidebar work
properly. I'll post a patch there in a minute.

Comment 2

[Andreas Kunz]

Attachment: patch: add AskJeeves files to makefile

Comment 3

[Andreas Kunz]

Comment on attachment 137503 [details] [diff] [review]
patch: add AskJeeves files to makefile

Requesting r= from timeless and sr= from dbaron.

Patch is basically by timeless, see bug 225490, first attachment.

Approval seeked because virtually no risk (only adding two files which are
already referred to in search.rdf(!)) and nice gain (additional search engine).

Comment 4

[Asa Dotzler [:asa]]

will this change have any impact on localizations?

Comment 5

[Andreas Kunz]

Asa: KaiRo (german localizator(?)) said: no

The added file just lists one more search engine (no matter which UI language is
active). 
The only new text seen by the user is the name of the engine and I don't see how
anybody might want to translate it. I just installed the Chinese language pack
and they do not translate the names of the other search engines. (It is not
possible without exchanging the search engine plugin, but they could've done that.)
Japanese download full build download features additional search plugins, but
does not change the existing ones.
All that just as further reassurance...

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 137503 [details] [diff] [review]
patch: add AskJeeves files to makefile

a=asa (on behalf of drivers) for checkin to Mozilla 1.6

Comment 7

[Andreas Kunz]

Now I need somebody to check this in...  biesi? timeless?
Thanks!

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in by timeless on 12/16/2003 21:42
marking fixed

Comment 9

[Andreas Kunz]

Verified with today's build.