231391 - Make "cumulate" option work properly in charts

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect, P2)

Description

[Gervase Markham [:gerv]]

Currently there are a few bugs in the "cumulate" option on new charts. 

Gerv

Comment 1

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This patch fixes 'cumulate' and a couple of other bugs/UI cleanups.

Gerv

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 139375 [details] [diff] [review]
Patch v.1

Dave - can we sneak this in to remove some simple known bugs in charting?

Gerv

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 139375 [details] [diff] [review]
Patch v.1

I have no clue what this is doing, and it'll take me longer to learn the chart
back end than we have between now and release time. Got someone else that knows
charts that can review it?

Comment 4

[Gervase Markham [:gerv]]

Comment on attachment 139375 [details] [diff] [review]
Patch v.1

Kiko has reviewed my charts stuff in the past... is he around right now?

Gerv

Comment 5

[Christian Reis]

Comment on attachment 139375 [details] [diff] [review]
Patch v.1

Looks quite correct. Make sure (I guess you have) that the wrapped buglist.cgi
link is actually working, since I'm a bit fuzzy on how chomping might work
there.

Again, a simple comment would have helped me understand what sort of changes
you intended there, but at least this one was short!

Comment 6

[Gervase Markham [:gerv]]

Requesting appr

Comment 7

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v
 <--  create-chart.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/reports/chart.png.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/chart.png.tmpl,v
 <--  chart.png.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.241; previous revision: 1.240
done
Checking in Bugzilla/Chart.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Chart.pm,v  <--  Chart.pm
new revision: 1.3; previous revision: 1.2
done

Gerv