Closed Bug 232161 Opened 21 years ago Closed 21 years ago

no UI to remove an invalid query

Categories

(Bugzilla :: Query/Bug List, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: dbaron, Assigned: gerv)

References

Details

Attachments

(1 file, 1 obsolete file)

There's no UI to remove a query that gives an error.

Steps to reproduce:
 1. create an account
 2. do a query for all bugs owned by that account, and save the query
 3. change the email address associated with that account
 4. run the query

Actual results:
 4. Error message that the user does not exist, and no way to remove the query
(since the only way to remove a saved query is now by running it)

Expected results:
 4. Error message for a saved query should give the option of removing the query
or editing it.
Assignee: justdave → gerv
Yep, this is my bug. I meant to fix it after I rearchitected saved queries, but
it slipped my mind. Apologies. I'll get to it this evening (GMT).

Gerv
Should also be able to *edit* an invalid query.  

Q: When a user changes his email address, shouldn't queries with that address
be automatically updated?
(In reply to comment #2)
> Q: When a user changes his email address, shouldn't queries with that address
> be automatically updated?

Yes, but that's bug 192052.
Attached patch Patch v.1 (obsolete) — Splinter Review
This adds a "remove saved search" link to all error pages caused by running
saved searches.

Gerv
Attachment #139935 - Flags: review?(justdave)
Attachment #139935 - Flags: review?(myk)
Comment on attachment 139935 [details] [diff] [review]
Patch v.1

add a way to load the search into the query page, too, and I'll go for it. 
("Edit this search")
Attachment #139935 - Flags: review?(justdave) → review-
Comment on attachment 139935 [details] [diff] [review]
Patch v.1

>+  <p>  
>+    Alternatively, you can    
>+    <a href="buglist.cgi?cmdtype=dorem&amp;remaction=forget&amp;namedcmd=
>+                  [% namedcmd FILTER html %]">forget</a>
>+    this saved search: '[% namedcmd FILTER html %]'.

Nits: indent [% namedcmd %] 13 spaces instead of 18 (so it lines up with the
"b" rather than the "s" in buglist.cgi), and make all of "forget this saved
search" be the link text, as "forget" is a small target (harder to see, harder
to click), unless you implement the "edit" link I just saw justdave requesting,
in which case "forget" is the appropriate link text.

r=myk
Attachment #139935 - Flags: review?(myk) → review+
Attached patch Patch v.2Splinter Review
This one adds editing capabilities. One begins to understand how powerful this
object-orientated malarkey is...

Gerv
Attachment #139935 - Attachment is obsolete: true
Attachment #139968 - Flags: review?(justdave)
Comment on attachment 139968 [details] [diff] [review]
Patch v.2

assuming it works, that looks good :)
Attachment #139968 - Flags: review?(justdave) → review+
approval, then?

Gerv
Flags: approval?
Flags: approval? → approval+
Fixed.

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.45; previous revision: 1.44
done

Gerv
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
Thats just horrible :) If we were using exceptions, the somethingin buglist.cgi
would catch the user-error. However, we dont' do that, so.....
Which version of bugzilla was this checked into? 2.18? When will this get on b.m.o?
It was checked into the latest CVS, and will get onto b.m.o. when it next
updates, which will be as soon as we've fixed any other regressions we find. :-)

Gerv
*** Bug 252064 has been marked as a duplicate of this bug. ***
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: