232548 - Element Properties should remove the properties with empty values

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Sekundes]

User-Agent:       
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

.

Reproducible: Always
Steps to Reproduce:
1.go to http://mozilla.org.
2.ensure "properties" is shown.(For example, right click in the navigation bar)
3.click a link.
4.right click in the area which contextmenu has "properties" before the
requested link is loaded.
5.wait until the new page is loaded.
6.contextmenu should still be here.
7.select "properties".
Actual Results:  
The first line of Element Properties said "Not properties set is shown."
Actually, the properties Text language is always shown.
The other properties are shown but with empty values.

Expected Results:  
The properties which have empty values should not be shown and "Not properties
set is shown." should not be exists if Text language is always shown(is it a
must to be shown?).

Comment 1

[Florian Quèze [:florian]]

Confirming with Firefox 0.9.3 on Windows XP

Comment 2

[Florian Quèze [:florian]]

Attachment: fix

Comment 3

[Daniel Brooks [:db48x]]

Comment on attachment 170405 [details] [diff] [review]
fix

looks good, r=db48x

Comment 4

[[e-mail]]

Comment on attachment 170405 [details] [diff] [review]
fix

I see now, you're basically null-checking against the document being torn down.

Personally I think the code is abusing .content when it actually means .top but
._content is definitiely deprecated.

Comment 5

[Florian Quèze [:florian]]

Fix checked in. Thanks Timeless.