234175 - Remove deprecated ConnectToDatabase() and quietly_check_login()/confirm_login() calls

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Teemu Mannermaa (:wicked)]

Need to remove calls to ConnectToDatabase() because it's deprecated and actually
does nothing. Database connection is established automatically in Bugzilla.pm.

Uses of quietly_check_login() and confirm_login() will be changed to use
Bugzilla->login directly.

I think this is better to do in one big patch than to gradually change call when
individual scripts are touched. This way we get rid of old code that just
confuses things once and for all. Besides, this is simple enough change to get
used hacking Bugzilla..

Comment 1

[Teemu Mannermaa (:wicked)]

Attachment: Changes, v1

This patch removes redundant login in attachment.cgi and so should fix bug
149167.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 141377 [details] [diff] [review]
Changes, v1

Since bbaetz wrote the Auth code, he's the best person to look at this

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 141377 [details] [diff] [review]
Changes, v1

You can leave out LOGIN_NORMAL; its teh default. I didn't do that in the compat
code because of the ?: - it was clearer when mentioned explicitly.

You don't need |use Bugzilla::Constants| in all cases then, either

Comment 4

[Teemu Mannermaa (:wicked)]

Attachment: Revised changes, v2

Comment 5

[Christian Reis]

Comment on attachment 141400 [details] [diff] [review]
Revised changes, v2

>Index: enter_bug.cgi
>-confirm_login() if (!(AnyEntryGroups()));
>+Bugzilla->login(LOGIN_REQUIRED) if (!(AnyEntryGroups()));

Nit: I would rather you had fixed this to use unless, but it's not a blocker; I
can do that before checking in if you like.

r=kiko after a 15-minute read.

Comment 6

[Christian Reis]

Dave, this touches a lot of files, though it's fairly trivial. I've had a good
look over it and there's nothing dangerous that I've found. Requesting approval
so we can have it in sooner than later.

Comment 7

[Dave Miller [:justdave]]

I want to wait for bbaetz's review.

Comment 8

[Bradley Baetz (:bbaetz)]

Comment on attachment 141400 [details] [diff] [review]
Revised changes, v2

This looks fine.

Comment 9

[Christian Reis]

Attachment: kiko_unrot

Unrotted this -- minor rejects that were easily fixed. This is what is going to
be checked in.

Comment 10

[Christian Reis]

Checked in -- thanks to Teemu for this great cleanup.