Closed
Bug 237540
Opened 20 years ago
Closed 20 years ago
edit-multiple.html.tmpl contains unused hidden field
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Bugzilla
Creating/Changing Bugs
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: dswegen, Assigned: dswegen)
Details
Attachments
(1 file)
589 bytes,
patch
|
timeless
:
review+
myk
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040219 Firefox/0.8.0+ Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040219 Firefox/0.8.0+ The list/edit-multiple.html.tmpl template file contains a hidden field which is unused in bugzilla according to grep -r. The field in question is named "multiupdate". Unless it is actually going to be used for something it should probably be removed so as to not confuse me. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Assignee | ||
Comment 1•20 years ago
|
||
Attachment #143960 -
Flags: review+
Assignee | ||
Updated•20 years ago
|
Flags: approval?
Updated•20 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 2•20 years ago
|
||
Comment on attachment 143960 [details] [diff] [review] Removes unused hidden field according to http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/webtools/bugzilla/template/ default/buglist/change-form.tmpl Myk put it there. Let's double-check with him what the intention was first.
Attachment #143960 -
Flags: review?(myk)
Updated•20 years ago
|
Flags: approval?
OS: Linux → All
Hardware: PC → All
Comment 3•20 years ago
|
||
Comment on attachment 143960 [details] [diff] [review] Removes unused hidden field Looks good to me. This was in the code before templatization; I just moved it over when I templatized buglist.cgi. r=myk
Attachment #143960 -
Flags: review?(myk)
Updated•20 years ago
|
Flags: approval+
Updated•20 years ago
|
Assignee: myk → dswegen
Target Milestone: --- → Bugzilla 2.18
Comment 4•20 years ago
|
||
Checking in template/en/default/list/edit-multiple.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v <-- edit-multiple.html.tmpl new revision: 1.15; previous revision: 1.14 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•