Closed
Bug 237919
Opened 20 years ago
Closed 20 years ago
Windows seamonkey static builds are busted
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stdowa+bugzilla, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
646 bytes,
patch
|
stdowa+bugzilla
:
review+
|
Details | Diff | Splinter Review |
nsNativeAppSupportBase.cpp make: *** No rule to make target `comctl32.lib', needed by `mozilla.exe'. Stop.
Reporter | ||
Comment 1•20 years ago
|
||
What in the build system changed that required this change?
Reporter | ||
Updated•20 years ago
|
Attachment #144268 -
Flags: review?(bryner)
Comment 2•20 years ago
|
||
With the patch my build died later at webshell/tests/viewer/nsStaticComponents.cpp: nsStaticComponents.cpp make[4]: *** No rule to make target `comctl32.lib', needed by `viewer.exe'. Stop.
Odd indeed. I'm not seeing this at all with my cross-compiled static win32 builds.
Comment 4•20 years ago
|
||
I'm building with VC++ .NET 2003, if it matters.
I'm beginning to think it matters though I don't know why. My native mingw static build worked fine as well. Can one of you attach a build log?
Ok, tracked it down. This is fallout from bug 232449. We grab the "static" libs from $(LIBS) $(HOST_LIBS) & $(EXTRA_DSO_LDOPTS) to properly track static library dependencies. MSVC builds are hitting this because they have the same suffix for static libs as they do for import libs.
Bah. That should be bug 232499 .
Comment on attachment 144268 [details] [diff] [review] s/LIBS/EXTRA_LIBS/g This static build mess really needs to be cleaned up or dropped.
Attachment #144268 -
Flags: review?(bryner) → review+
Comment on attachment 144268 [details] [diff] [review] s/LIBS/EXTRA_LIBS/g This static build mess really needs to be cleaned up or dropped.
Attachment #144268 -
Flags: approval1.7?
Comment 10•20 years ago
|
||
Comment on attachment 144268 [details] [diff] [review] s/LIBS/EXTRA_LIBS/g a=chofmann for 1.7
Attachment #144268 -
Flags: approval1.7? → approval1.7+
Updated•20 years ago
|
Assignee: nobody → sdwalker
Comment 11•20 years ago
|
||
Checking in Makefile.in; /cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v <-- Makefile.in new revision: 1.259; previous revision: 1.258 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 12•20 years ago
|
||
Reopening; viewer still needs to be fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Updated•20 years ago
|
Assignee: sdwalker → nobody
Status: REOPENED → NEW
Reporter | ||
Comment 13•20 years ago
|
||
Comment on attachment 144268 [details] [diff] [review] s/LIBS/EXTRA_LIBS/g This patch is in for 1.7.
Attachment #144268 -
Attachment is obsolete: true
Comment 14•20 years ago
|
||
Attachment #148804 -
Flags: review?(sdwalker)
Reporter | ||
Updated•20 years ago
|
Attachment #148804 -
Flags: review?(sdwalker) → review+
Comment 15•20 years ago
|
||
The last patch was checked in at May 21th: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&branch=&root=/cvsroot&subdir=mozilla/webshell/tests/viewer&command=DIFF_FRAMESET&rev1=1.181&rev2=1.182 Especially after reading comment #12 it sounds like this bug is fixed now, right?
Updated•20 years ago
|
Status: NEW → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•