Closed Bug 237919 Opened 20 years ago Closed 20 years ago

Windows seamonkey static builds are busted

Categories

(SeaMonkey :: Build Config, defect)

x86
Windows XP
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stdowa+bugzilla, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

nsNativeAppSupportBase.cpp
make: *** No rule to make target `comctl32.lib', needed by `mozilla.exe'.  Stop.
Attached patch s/LIBS/EXTRA_LIBS/g (obsolete) — Splinter Review
What in the build system changed that required this change?
Attachment #144268 - Flags: review?(bryner)
With the patch my build died later at webshell/tests/viewer/nsStaticComponents.cpp:

nsStaticComponents.cpp
make[4]: *** No rule to make target `comctl32.lib', needed by `viewer.exe'.  Stop.
Odd indeed.  I'm not seeing this at all with my cross-compiled static win32 builds.
I'm building with VC++ .NET 2003, if it matters.
I'm beginning to think it matters though I don't know why.  My native mingw
static build worked fine as well.  Can one of you attach a build log?
Ok, tracked it down.  This is fallout from bug 232449.  We grab the "static"
libs from $(LIBS) $(HOST_LIBS) & $(EXTRA_DSO_LDOPTS) to properly track static
library dependencies.  MSVC builds are hitting this because they have the same
suffix for static libs as they do for import libs.
Bah.  That should be bug 232499 .
Comment on attachment 144268 [details] [diff] [review]
s/LIBS/EXTRA_LIBS/g

This static build mess really needs to be cleaned up or dropped.
Attachment #144268 - Flags: review?(bryner) → review+
Comment on attachment 144268 [details] [diff] [review]
s/LIBS/EXTRA_LIBS/g

This static build mess really needs to be cleaned up or dropped.
Attachment #144268 - Flags: approval1.7?
Comment on attachment 144268 [details] [diff] [review]
s/LIBS/EXTRA_LIBS/g

a=chofmann for 1.7
Attachment #144268 - Flags: approval1.7? → approval1.7+
Assignee: nobody → sdwalker
Checking in Makefile.in;
/cvsroot/mozilla/xpfe/bootstrap/Makefile.in,v  <--  Makefile.in
new revision: 1.259; previous revision: 1.258
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Reopening; viewer still needs to be fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: sdwalker → nobody
Status: REOPENED → NEW
Comment on attachment 144268 [details] [diff] [review]
s/LIBS/EXTRA_LIBS/g

This patch is in for 1.7.
Attachment #144268 - Attachment is obsolete: true
Attached patch fix viewerSplinter Review
Attachment #148804 - Flags: review?(sdwalker)
Attachment #148804 - Flags: review?(sdwalker) → review+
Status: NEW → RESOLVED
Closed: 20 years ago20 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: