238683 - Use of uninitialized value in concatenation in Bugzilla/CGI.pm

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[corporate_gadfly]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040302 Galeon/1.3.13
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040302 Galeon/1.3.13

I get tons of these errors in the error_log:

Use of uninitialized value in concatenation (.) or string at Bugzilla/CGI.pm
line 121

Here's a diff that takes out the extra $ sign after boundary:
Index: Bugzilla/CGI.pm
===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v
retrieving revision 1.9
diff -r1.9 CGI.pm
121c121
<     $self->{'separator'} = "\r\n--$boundary$\r\n";
---
>     $self->{'separator'} = "\r\n--$boundary\r\n";



Reproducible: Always
Steps to Reproduce:

Comment 1

[Vlad Dascalu]

Could you rediff using the unified format (diff -u) and post that as an 
attachment? Thanks!

Comment 2

[corporate_gadfly]

Attachment: patch created with diff -u

As requested, patch created with diff -u

Comment 3

[Christian Reis]

Ouch. A regression from bug Stephen's patch at bug 226251.

Comment 4

[corporate_gadfly]

Are you sure you meant to assign this to me? hehe.

Comment 5

[Dave Miller [:justdave]]

yep, that's common practice here, bug gets assigned to the person who writes the
patch to fix it. :)  Makes it easy to figure out who the contributors are when
you look at fixed bugs. :)

Comment 6

[Vlad Dascalu]

Checking in Bugzilla/CGI.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/CGI.pm,v  <--  CGI.pm
new revision: 1.10; previous revision: 1.9
done

Comment 7

[Vlad Dascalu]

CCing Stephen to make him aware of this (he wanted to push it further in CGI.pm)