238869 - remove %FORM from votes.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Dave Miller [:justdave]]

This should be another (relatively) easy one.

47:my $action = $::FORM{'action'} || 
48:                                 ($::FORM{'bug_id'} ? "show_bug" : "show_user");
51:    ($action eq "show_user" && defined($::FORM{'user'}))) 
65:if (defined $::FORM{'bug_id'}) {
66:  ValidateBugID($::FORM{'bug_id'});
93:    my $bug_id = $::FORM{'bug_id'} 
127:    my $bug_id = $::FORM{'bug_id'} || "";
129:    my $name = $::FORM{'user'} || Bugzilla->user->login;
239:    my @buglist = grep {/^[1-9][0-9]*$/} keys(%::FORM);
244:        if (!defined($::FORM{'delete_all_votes'})) {
250:        elsif ($::FORM{'delete_all_votes'} == 0) {
263:      detaint_natural($::FORM{$id})
288:            $prodcount{$prod} += $::FORM{$id};
291:            ($::FORM{$id} <= $max)               
295:                                 votes => $::FORM{$id}});
329:        if ($::FORM{$id} > 0) {
331:                     VALUES ($who, $id, $::FORM{$id})");

Comment 1

[Christian Reis]

Attachment: kiko_v1: fix

There's an XXX question there:

-    my @buglist = grep {/^[1-9][0-9]*$/} keys(%::FORM);
+    my @buglist = grep {/^[1-9][0-9]*$/} $cgi->param();

I think this does what I want and via testing it looks correct, but I'm no
expert!

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 144986 [details] [diff] [review]
kiko_v1: fix

>Index: votes.cgi
>-    my @buglist = grep {/^[1-9][0-9]*$/} keys(%::FORM);
>+
>+    # XXX is this correct?
>+    my @buglist = grep {/^[1-9][0-9]*$/} $cgi->param();

Looks correct to me...	have you tested it? :)

Comment 3

[Christian Reis]

Yes, I did, but I wanted to make sure the code looked correct. r=justdave?

Comment 4

[Vlad Dascalu]

Comment on attachment 144986 [details] [diff] [review]
kiko_v1: fix

Looks good.

+
+    # XXX is this correct?
+    my @buglist = grep {/^[1-9][0-9]*$/} $cgi->param();

It looks ok to me and justdave said it's correct and you tested it and it
works, so I think you can drop the XXX comment :-)

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 144986 [details] [diff] [review]
kiko_v1: fix

r= justdave assuming you nuke the XXX comment prior to checkin.

Comment 6

[Christian Reis]

/cvsroot/mozilla/webtools/bugzilla/votes.cgi,v  <--  votes.cgi
new revision: 1.17; previous revision: 1.16

One more down. Thanks!