239885 - There is no sendmail for windows (in checksetup.pl)

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Vlad Dascalu]

Checksetup.pl should not remind about sendmail if we're running on windows.

Comment 1

[Vlad Dascalu]

Attachment: Patch

Comment 2

[Vlad Dascalu]

(spin-off from bug 239852)

Comment 3

[Joel Peshkin]

Comment on attachment 145615 [details] [diff] [review]
Patch

r=joel if you've checked this on a Win32 box.

I'll resist the temptation to insist on an else condition scolding the user for
the choice of OS.

Comment 4

[Vlad Dascalu]

> I'll resist the temptation to insist on an else condition scolding the user for
> the choice of OS.

Well actually what we would need to do on a Windows install would be to provide
out-of-the-box MTA support for something different than sendmail (like for
example a SMTP server using the SMTP perl module). But that's what JayPee is
working on :-)

Comment 5

[Bruce Armstrong]

Perhaps it should be modified to give the 'sendmail' notice to Unix users and 
a 'make sure you've applied the manual Net:SMTP patch' to windows users.

Comment 6

[Vlad Dascalu]

> r=joel if you've checked this on a Win32 box.

Hmm, you're right. Bruce used $^0 instead of $^O for Win-like environment
detection, which is different from the previous testing conditions in
checksetup.pl. I've fixed the spelling error upon checkin.

> a 'make sure you've applied the manual Net:SMTP patch' to windows users.

That patch is not even available in mozilla.org's CVS. We should work to get
things right instead of pointing towards local hacks. The MTA bug that JayPee
and others are working on is pretty close anyway.

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.272; previous revision: 1.271
done

Comment 7

[Vlad Dascalu]

Attachment: Patch (the same as the previous one with the 0 --> O spelling mistake fixed)

Comment 8

[Dave Miller [:justdave]]

Wish I'd seen this bug before it went in...  I think we should get rid of it for
Unix users, too.  When's the last time you saw a machine with Sendmail older
than 8.9 on it? :)  We should mention the prereq in the docs and get rid of it
altogether out of checksetup.pl.  Especially since it seems to make some people
think it's complaining about the lack of a sufficient sendmail version when it
really has no way to know.

Comment 9

[Dave Miller [:justdave]]

bug 240060 has been filed to continue this.