239888 - horizontal scrollbar is displayed

Status: RESOLVED DUPLICATE of bug 239477

(Core :: Layout: Text and Fonts, defect)

Description

[Koike Kazuhiko]

Horizontal scrollbar is displayed when right-aligned text has
a trailing space.

Testcase:
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2171&action=view

Saito-san, please post your patch.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Duplicate of bug 239477?

Comment 2

[Hideo Saito]

Attachment: patch

> Duplicate of bug 239477?

Yes, I think so.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 145658 [details] [diff] [review]
patch

The |deltaWidth| is already passed back up to the caller so they can shrink. 
Is there something wrong with that code?

Also, subtracting from the combined area's width is almost always the wrong
thing to do.  The last thing in the line need not be the farthest right --
there could be something relatively positioned with a value of 'left' that
means trimming the whitespace shouldn't affect the combined area.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

...although the combined area is mostly (but not entirely) recomputed later in
nsLineLayout::RelativePositionFrames.  So perhaps just subtracting is OK,
although it would break if we implemented 'inline-block'.

Comment 5

[Koike Kazuhiko]

*** This bug has been marked as a duplicate of 239477 ***