240131 - NPStream's necko stream ownership and handling seems shady.

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Johnny Stenback (:jst)]

Seems like _destroystream() (in ns4xPlugin.cpp) should do more cleaning up of
the underlying necko streams than it does, like, closing it etc. And the
ownership of the underlying stream is far from obvious, and should be clarified
in the code.

Comment 1

[Josh Aas]

From related code comments the primary concern seems to be what we store for stream ndata. I'm working on that code now, taking this.

Comment 2

[Josh Aas]

Attachment: fix v1.0

I didn't find any problems during my review of stream cleanup, but there are some things that can be more clear. This patch is largely improving comments, but it also does a little bit of re-organization and makes owning references more clear. It pushes necessary strong references further down in the stream cleanup process to make their necessity clearer.

Comment 3

[Josh Aas]

Try server run:

https://tbpl.mozilla.org/?tree=Try&rev=f4b4a651e203

Comment 4

[Josh Aas]

pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/407014e60866

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/407014e60866