Closed
Bug 244137
Opened 20 years ago
Closed 20 years ago
[FIX]Anchor traversals in an HTML document in a jar don't add history entries
Categories
(Core :: DOM: Navigation, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
()
Details
Attachments
(1 file)
|
4.01 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Try loading URL in the url field.... clicking on links therein does not update session history.
|
Assignee | |
Comment 1•20 years ago
|
||
The problem is that nsJARURI::Equals is buggy -- it ignores the fragment identifier when doing the comparison. Probably my fault.
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Anchor traversals in an HTML document in a jar don't add history entries → [FIX]Anchor traversals in an HTML document in a jar don't add history entries
Target Milestone: --- → mozilla1.8alpha
|
|
Assignee | |
Comment 2•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #148967 -
Flags: superreview?(darin)
Attachment #148967 -
Flags: review?(darin)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 148967 [details] [diff] [review] Fix, following example of nsStandardURL why not use nsRefPtr<nsJARURI>? then you don't need to code the NS_RELEASE lines. r+sr=darin either way.
Attachment #148967 -
Flags: superreview?(darin)
Attachment #148967 -
Flags: superreview+
Attachment #148967 -
Flags: review?(darin)
Attachment #148967 -
Flags: review+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Fixed for 1.8a2.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•