Closed Bug 245918 Opened 20 years ago Closed 20 years ago

Use speed-enhanced cygwin-wrapper script for all cygwin-wrappers

Categories

(SeaMonkey :: Build Config, enhancement)

All
Windows XP
enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.8alpha4

People

(Reporter: netdragon, Assigned: netdragon)

Details

Attachments

(1 file)

nsprpub/cygwin-wrapper and directory/c-sdk still spawn sed and are duplicates.

Could they be made to use $_topsrcdir/build/cygwin-wrapper? This would also
speed up builds and make the build system less complex.

http://lxr.mozilla.org/seamonkey/source/directory/c-sdk/config/cygwin-wrapper
http://lxr.mozilla.org/seamonkey/source/nsprpub/build/cygwin-wrapper
http://lxr.mozilla.org/seamonkey/source/build/cygwin-wrapper

See also:

http://bugzilla.mozilla.org/show_bug.cgi?id=206643
Where the speedup was checked in. There was one more checkin afterwards to fix
afterstate perl.
I guess they'd have to simply be duplicated over since you can build NSPR and
c-sdk alone.
Assignee: nobody → netdemonz
Status: NEW → ASSIGNED
Attachment #150300 - Flags: review+
Comment on attachment 150300 [details] [diff] [review]
patch made from the ./mozilla dir

Can you get this checked in?
Attachment #150300 - Flags: approval1.8a3?
Comment on attachment 150300 [details] [diff] [review]
patch made from the ./mozilla dir

a=asa for checkin to 1.8a3
Attachment #150300 - Flags: approval1.8a3? → approval1.8a3+
The patch has been checked into the Mozilla trunk, NSPR trunk & LDAP trunk.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha4
Is there a way to look into the tinderbox trees and see if there is any speedup
on the NT NSPR builds, or would I have to grab the tree from times straddling
the checkins to see?

V
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: