246089 - Calls to CheckAndPopulateRecipients() do not check return value

Status: RESOLVED WORKSFORME

(MailNews Core :: Composition, defect)

Description

[Eyal Rozenberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040602
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040602

CheckAndPopulateRecipients() might fail - that's why it returns NS_IMETHODIMP,
not void. However, the calls to it from MsgComposeCommands.js don't seem to
check its return value; they only catch exceptions... but a non-NS_OK value may
be returned without throwing exceptions. Example: see bug 238098 . Note also
that bug 152679 says that some retvals from this function may even be invalid...

It also seems that method should be split into something which determines the
message type (text or HTML) and something which sorts out all the recipients;
bug 99674 mentions this, but I also mention it here because when this method is
called, it almost seems as if the only thing the code cares about is the
HTML/plain text decision (the calling function is 'DetermineHTMLAction' which
returns 'gSendFormat').


Reproducible: Always
Steps to Reproduce:

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 3

[Eyal Rozenberg]

Hmph. Four years and nobody has read this.

Comment 4

[Joshua Cranmer [:jcranmer]]

This method does not exist any more.