247044 - Cannot select different SMTP server (except for POP3 accounts)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Anthony Howe]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040613
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040613

If I add a new SMTP server and try then change the SMTP server of an account, I
can select it in the list, BUT the OK button refuses to accept my selection.

I have about 7 SMTP server currently and I found that even if I try to select an
existing server for an account, the OK button refuses to work.

Reproducible: Always
Steps to Reproduce:
1. Edit > Mail & Newsgroup Preferences
2. Select an account
3. Select Server Settings
4. On the RHS click Advanced
5. Select the SMTP tab.
6. In the drop list, select a different SMTP server
7. Click OK.

Actual Results:  
Clicking on the OK button fails to do anything. The dialogue remains open and
the only working button is CANCEL.


Expected Results:  
Umm. Clicking OK button should accept my selection so I can use the new SMTP server.

Comment 1

[Stefan Borggraefe]

WFM with a Linux build from today.

Do you see any JavaScript error in the JavaScript Console when you press the OK
button?

Comment 2

[WADA:World Anti-bad-Duping Agency]

Anthony Howe and Stefan Borggraefe, which is mail account type, POP3 or IMAP?

I experienced same problem for newly created IMAP account(dummy for test
purpose) on 2004-06-15-07(Trunk)/Win-2K, but no problem for POP3 account.
When I pressed OK button of Account Settings/Server Settings panel of IMAP
account, following error message was displayed on JavaScript Console.
> Error: gFirstDeferredAccount has no properties
> Source File: chrome://messenger/content/am-server-advanced.js 
> Line: 143

Comment 3

[Anthony Howe]

All 14 mail accounts are IMAP based.

Comment 4

[Stefan Borggraefe]

Confirming. This is broken for every account type except POP3. Of course I only
tried POP3 before. ;-)

Comment 5

[Stefan Borggraefe]

Attachment: Patch

This fixes the bug. Without the if condition the JavaScript error described in
comment 2 is triggered.

The patch also fixes two JavaScript strict warnings ("Assignment to undeclared
variable radioGroup/gPrefsBundle...").

Comment 6

[David :Bienvenu]

Comment on attachment 150974 [details] [diff] [review]
Patch

yes, thx. sorry about that...

Comment 7

[Scott MacGregor]

Comment on attachment 150974 [details] [diff] [review]
Patch

Was this regression caused by a particular change? If so what was the bug #?
I"d like to make sure it gets ported to aviary 1.0 if the bug that caused it
exists there.

Comment 8

[Stefan Borggraefe]

Scott: This was caused by bug 243837. David already added a note there.

Fix checked in.