247720 - header only pop3 option must ignore disk space limit

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Howard Chu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040619
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040619

With "headers only" already selected, somehow my prefs got changed and the Disk
Space "Don't download messages over 50kb" option was selected. (I have no idea
how that happened, just suddenly the behavior changed and I went crazy looking
thru the code trying to find what was wrong...)

There's a check in nsPop3Protocol that says "message previously left on server,
see if the max download size has changed, because we may want to download the
message this time around." (around line 2665). The resulting effect is that on
the next GetNewMessages call, the full body of a header-only message is
automatically downloaded (if it's smaller than the size limit) even though the
header wasn't explicitly selected for downloading. Also the header is not
deleted, so both are present in the Inbox.

So, the fix for this would be, when the headers_only option is set, disable the
Disk Space option, and always leave the size_limit at zero.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Howard Chu]

Attachment: Ignore size limit

Leave the size limit at default (0) when the headers_only option is set.

Comment 2

[Wayne Mery (:wsmwk)]

confirm to get patch