Closed
Bug 247720
Opened 20 years ago
Closed 19 years ago
header only pop3 option must ignore disk space limit
Categories
(MailNews Core :: Networking: POP, defect)
MailNews Core
Networking: POP
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: hyc, Assigned: sspitzer)
Details
Attachments
(1 file)
1.21 KB,
patch
|
Bienvenu
:
review+
mscott
:
superreview+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040619 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040619 With "headers only" already selected, somehow my prefs got changed and the Disk Space "Don't download messages over 50kb" option was selected. (I have no idea how that happened, just suddenly the behavior changed and I went crazy looking thru the code trying to find what was wrong...) There's a check in nsPop3Protocol that says "message previously left on server, see if the max download size has changed, because we may want to download the message this time around." (around line 2665). The resulting effect is that on the next GetNewMessages call, the full body of a header-only message is automatically downloaded (if it's smaller than the size limit) even though the header wasn't explicitly selected for downloading. Also the header is not deleted, so both are present in the Inbox. So, the fix for this would be, when the headers_only option is set, disable the Disk Space option, and always leave the size_limit at zero. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Reporter | ||
Comment 1•20 years ago
|
||
Leave the size limit at default (0) when the headers_only option is set.
Reporter | ||
Updated•20 years ago
|
Attachment #151239 -
Flags: review?(bienvenu)
Updated•20 years ago
|
Attachment #151239 -
Flags: review?(bienvenu) → review+
Updated•20 years ago
|
Product: MailNews → Core
Updated•19 years ago
|
Attachment #151239 -
Flags: superreview?(mscott)
Updated•19 years ago
|
Attachment #151239 -
Flags: superreview?(mscott) → superreview+
Updated•19 years ago
|
Attachment #151239 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #151239 -
Flags: approval1.8b4? → approval1.8b4+
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•