Closed
Bug 24823
Opened 25 years ago
Closed 22 years ago
The top of a bug description should have last modified date
Categories
(Bugzilla :: User Interface, defect, P3)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.18
People
(Reporter: alan-lists, Assigned: vkissoyan)
Details
Attachments
(1 file, 7 obsolete files)
4.61 KB,
patch
|
bbaetz
:
review+
bbaetz
:
review+
|
Details | Diff | Splinter Review |
There are often bugs that I watch, but am not CCed. Many of these bugs may have several comments. I would be nice to have a the top of a bug description next to the bug number a last updated field and/or a last commented filed. This would keep one from scrolling down though the comments just to find the bug had not been changed in 2 months. Last updated field: is last time any thing on the bug changed (priority, component, ect...) Last Commented field is the last time a text comment was added in the additional comments section. The last comments ones is the one i would rather have, but either or both would be hepful.
Comment 1•24 years ago
|
||
tara@tequilarista.org is the new owner of Bugzilla and Bonsai. (For details, see my posting in netscape.public.mozilla.webtools, news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)
Assignee: terry → tara
Comment 2•24 years ago
|
||
You could use a query: list the bug numbers you want to watch in the "include" field, click "change columns", add "changeddate", and then sort the query by "changeddate".
Comment 3•24 years ago
|
||
Adding default QA contact to all open Webtools/Bugzilla bugs lacking one. Sorry for the spam.
QA Contact: matty
Updated•23 years ago
|
Target Milestone: --- → Bugzilla 2.16
Comment 4•23 years ago
|
||
-> Bugzilla product, IMO mostly UI question, reassigning.
Assignee: tara → myk
Component: Bugzilla → User Interface
Product: Webtools → Bugzilla
Version: other → unspecified
Updated•23 years ago
|
Summary: The top of a bug desccription should have last modified date → The top of a bug description should have last modified date
Comment 5•23 years ago
|
||
setting default owner
Comment 6•23 years ago
|
||
Makes sense. This might be part of a general redesign of the "show bug" screen.
Comment 7•23 years ago
|
||
We are currently trying to wrap up Bugzilla 2.16. We are now close enough to release time that anything that wasn't already ranked at P1 isn't going to make the cut. Thus this is being retargetted at 2.18. If you strongly disagree with this retargetting, please comment, however, be aware that we only have about 2 weeks left to review and test anything at this point, and we intend to devote this time to the remaining bugs that were designated as release blockers.
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18
Comment 8•22 years ago
|
||
While implementing last-modified for the bug report, why not send the HTTP header as well?
Assignee | ||
Comment 9•22 years ago
|
||
I'm submitting my first patch here... so let me know what you think. I have added in this feature using the lastdiffed column in the bug table. I've done my work on the "TIP" / trunk as you guys call it and I did updates fairly recently so these patches should be good. I had to modify default templates and also used table changes to right-align the date. (perhapse over-stepped my bounds, but it looked like crap at first) I also fixed a spot where the non-filtered version of the short_desc was still being displayed, just noticed it there and fixed it, if it was that way for a reason, that should be backed out. see "filtered_desc" change in edit.html.tmpl.patch
Assignee | ||
Comment 10•22 years ago
|
||
here are the three files that I modified. Again these are very recent edits done against the tip.
Assignee | ||
Comment 11•22 years ago
|
||
made provisions for pulling in the lastdiffed column from the bugs table
Attachment #87443 -
Attachment is obsolete: true
Assignee | ||
Comment 12•22 years ago
|
||
fixed a filtered_desc that was setup, but not used and also added h3 for the bug.lastdiffed value so we can pass to the header template
Assignee | ||
Comment 13•22 years ago
|
||
set default last modified, add in extra table data for the right-aligned last modified date
Comment 14•22 years ago
|
||
Comment on attachment 87445 [details] [diff] [review] bug_form.pl.patch Should be using delta_ts and not lastdiffed. delta_ts is the modified timestamp on the bug, lastdiffed is the timestamp for when mail was last sent about the bug, which depending on the preferences of all the people on the bug, might not be the same.
Attachment #87445 -
Flags: review-
Comment 15•22 years ago
|
||
Comment on attachment 87447 [details] [diff] [review] edit.html.tmpl.patch we should probably make this a little more generic for the purpose of the header template and make h3 a generic text field. Pass in the "Last Modified: " with the date as an entire string from bug/edit.html.tmpl
Attachment #87447 -
Flags: review-
Comment 16•22 years ago
|
||
Comment on attachment 87450 [details] [diff] [review] headler.html.tmpl.patch needs-work: See reasons from the previous patch. We should pass in the "Last Modified: " bit, too, instead of assuming h3 will contain a modification date.
Attachment #87450 -
Flags: review-
Assignee | ||
Comment 17•22 years ago
|
||
Sorry about the 3-part previous patch. I believe I've addressed everything that needed work. Apparently delta_ts is the correct value to display. No longer using lastdiffed, delta_ts is the correct field in bugs table to display. I used some formatting code in bug_form and applied it to the value since it was not displayable in its database format which cannot use the date_format() function. (Apparently the 2 _ts fields are diff data types in MySQL one that can use the date_format, and one that cannot) I used a simple substring code to derive the display value in bug_form.pl. The value text value "Last Modified: " is appended in edit.html.tmpl and passed to header.html.tmpl which then right-aligns the h3 TD displaying the value to the user.
Attachment #87445 -
Attachment is obsolete: true
Attachment #87447 -
Attachment is obsolete: true
Attachment #87450 -
Attachment is obsolete: true
Comment 18•22 years ago
|
||
Comment on attachment 88084 [details] [diff] [review] patch v2 This patch no longer applies to the tip cleanly. However, it only had one conflict and was easy to fix. Also, the title doesn't need to be filtered in edit.html.tmpl because header.html.tmpl does the filtering there.
Attachment #88084 -
Flags: review-
Comment 19•22 years ago
|
||
Attachment #88084 -
Attachment is obsolete: true
Comment 20•22 years ago
|
||
Comment on attachment 94736 [details] [diff] [review] Patch v3 - Vaskin's patch with review comments fixed wtf did I come up with that name? Sorry about that. Vaskin, not Vladimir
Attachment #94736 -
Attachment description: Patch v3 - Vladimir's patch with review comments fixed → Patch v3 - Vaskin's patch with review comments fixed
Comment 22•22 years ago
|
||
Comment on attachment 94736 [details] [diff] [review] Patch v3 - Vaskin's patch with review comments fixed inheriting my r= from the previous patch, but since I slightly modified the patch, need a 2nd r= from someone else
Attachment #94736 -
Flags: review+
Comment 23•22 years ago
|
||
Comment on attachment 94736 [details] [diff] [review] Patch v3 - Vaskin's patch with review comments fixed There are tabs, and the header.tmpl.html comment shouldn't refer to this specific use - other places may use it in the future.
Attachment #94736 -
Flags: review-
Assignee | ||
Comment 24•22 years ago
|
||
Ok, I've fixed a major issue with the other patches which was that they would mung delta_ts and cause all edits to the bug to throw a Mid-Air collision (complete app showstopper). I implemented my changes with an alias column on the original sql statement called calc_disp_date, which then is used only for displaying this date. I don't know if there is a reasoable way to do this through the TT formatting since it probably doesn't understand the format used for the delta_ts field. However if someone does know how to do that, it might be preferable rather than using an alias field in the sql statement, which is kind-of messy. I've ammended the comments to more generally describe what h3 is for. "Right-aligned subheader."
Attachment #94736 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Comment 25•22 years ago
|
||
I think that, like the potential moving of the CC field that we've discussed recently, this should wait for the redesign of show_bug - for exactly the same reasons. If we are going to change the UI of this page, we should (as far as possible) do it in one go. Gerv
Comment 26•22 years ago
|
||
OK, but don't we need to make sure that the person doing the redesign knows this field needs to be factored in? Since this is a completely new piece of UI, I don't think the redesign applies here. If we don't put this in, it won't be there to move in the redesign.
Comment 27•22 years ago
|
||
Yeah,I don't think that this is getting in the way of the mythical resdesign
Comment 28•22 years ago
|
||
Comment on attachment 94854 [details] [diff] [review] proposed patch v4 IF we keep waiting for redesigns, nothing will ever get done Note that you still have a tab (the last chunk of the patch, for the td) Whever applies this should fix that, or I'll check it in later this afternoon when I find a clean tree r=bbaetz x2
Attachment #94854 -
Flags: review+
Assignee | ||
Comment 29•22 years ago
|
||
Brought it into sync with current HEAD since there were conflicts since a recent commit. Hopefully I took out the annoying tab.
Attachment #94854 -
Attachment is obsolete: true
Comment 30•22 years ago
|
||
Comment on attachment 95042 [details] [diff] [review] proposed patch v5 Theres still one more tab, but I've removed that locally r=bbaetz
Attachment #95042 -
Flags: review+
Comment 31•22 years ago
|
||
and checked in, thanks
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
QA Contact: matty_is_a_geek → default-qa
Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•