248566 - <input type="file" /> gets focused by any alt+navigation key

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[XFox]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040623
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040623

If a file input exists on a page, hitting alt+left (shortcut for hitting the
back button) gives focus to the file input instead of going to the previous
page. User is left with no choice but to manually click the back button.

Reproducible: Always
Steps to Reproduce:
1. Create a text input
2. Press alt+left in the page



Actual Results:  
text input steals focus (as if it were a text input).

Expected Results:  
The browser should jump to the previous page.

Comment 1

[Aaron Leventhal]

I suspect this was caused by Neo's checkin for bug 206376

Comment 2

[Aaron Leventhal]

This also happens for alt+home, alt+right, alt+insert, alt+delete, alt+f2 ...

Perhaps whenever charCode is 0?

Comment 3

[Nian Liu(n/a in a long time)]

Attachment: patch

if i understand correctly, accesskey only support single character. and for
special key like "F1", we can't specify it as a accesskey in html. here is the
patch.

Comment 4

[[e-mail]]

Any <input accesskey=""> will trigger this bug...

Comment 5

[Aaron Leventhal]

Comment on attachment 151993 [details] [diff] [review]
patch

How about 
|if (!accessKey.IsEmpty())| instead? That might be more optimal. Anyway, you
would need spaces around the >. Other than that looks right.

Comment 6

[Aaron Leventhal]

Neo, we need to fix it so SetAccessKey(emptystring) does nothing

Comment 7

[[e-mail]]

Attachment: Stop form frames registering empty access keys

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 152023 [details] [diff] [review]
Stop form frames registering empty access keys

You had me confused for a minute. The summary should be "Stop form frames
registering *empty* access keys" :-)

Comment 9

[[e-mail]]

Comment on attachment 152023 [details] [diff] [review]
Stop form frames registering empty access keys

D'oh!

Comment 10

[[e-mail]]

Fix checked in.

Comment 11

[Nian Liu(n/a in a long time)]

*** Bug 250009 has been marked as a duplicate of this bug. ***