249107 - directory listings coming from session history (cache?) displayed in raw form

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

A directory listing displayed because the user presses back or forward is
displayed in raw form rather than in HTML-ized form.

Steps to reproduce:
 * load file:///
 * click on a directory
 * hit the back button

Actual results:
 * garbage that vaguely resembles the directory listing

Expected results:
 * HTML directory listing

I'm seeing this in a FF trunk build from a few days ago.  Others on IRC see it
as well.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

most likely caused by bug 247607

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

happens on windows as well.

Comment 3

[[e-mail]]

I blame
http://lxr.mozilla.org/seamonkey/source/xpfe/components/directory/nsDirectoryViewer.cpp#1492
and
http://lxr.mozilla.org/seamonkey/source/xpfe/components/directory/nsDirectoryViewer.cpp#1446

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

so... this is caused by combining the patches from Bug 214626 with bug 247607

The former one means that docshell sets the content type of channels from
session history. the latter means that the conversion http-index-format -> html
is now triggered by the channel's content type.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: hackaround

this patch would make this bug go away.

it'd also mean that after following an <a type="foo/bar" href="42"> link, then
going elsewhere, then going back, the 42 page may now be rendered as a
different content type...

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 249209 has been marked as a duplicate of this bug. ***

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

this is better. does not regress <a type="..."> session history.

Comment 8

[Darin Fisher]

biesi: care to explain why this patch works?

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

"pretty well"

more seriously:
Before, docshell got the content type off the channel, and stored it in session
history (the AddToSessionHistory part of this patch). Later, after hitting back,
the content type was read from the session history entry and set on the channel
as a content type hint (i.e. before opening it) (nsDocShell::LoadHistoryEntry)

since this is a file: uri, it then reported the content type that was set as a
hint on it as its type - text/html.
unfortunately this is really an http-index stream.

So, I'm changing it so that I'm only storing the content type _hint_ in session
history, not what the channel reported as its actual type, and am re-setting
that hint as the new hint when clicking back.
since directory listings, like most loads, do not have such a hint set, no hint
gets set, and the file channel reports http-index-format as its type, and
everything works as expected.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #9)
> "pretty well"

(aw, you wrote "why" not "how". oh well)

Comment 11

[Darin Fisher]

Comment on attachment 152032 [details] [diff] [review]
patch v2

sr=darin

Comment 12

[Johnny Stenback (:jst)]

Comment on attachment 152032 [details] [diff] [review]
patch v2

r=jst

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsDocShell.cpp;
/cvsroot/mozilla/docshell/base/nsDocShell.cpp,v  <--  nsDocShell.cpp
new revision: 1.603; previous revision: 1.602
done
Checking in nsDocShell.h;
/cvsroot/mozilla/docshell/base/nsDocShell.h,v  <--  nsDocShell.h
new revision: 1.152; previous revision: 1.151
done

Comment 14

[benc]

v, per cvs comments.

Comment 15

[Boris Zbarsky [:bzbarsky]]

*** Bug 275765 has been marked as a duplicate of this bug. ***