Closed
Bug 249282
Opened 20 years ago
Closed 20 years ago
Permit mixing of \ and / in file:// URLs under Win32
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
(Whiteboard: [patch])
Attachments
(1 file, 1 obsolete file)
8.56 KB,
patch
|
bzbarsky
:
superreview+
mkaply
:
approval-aviary-
mkaply
:
approval1.7.5-
mkaply
:
approval1.7.6+
|
Details | Diff | Splinter Review |
We should fixup any \'s in file:// URLs under Win32 builds since we know that path segments cannot contain \'s under Win32. This will help workaround a problem with DB2 UDB 7.1 (see bug 13607) and will likely help with other Win32 specific apps that utilize HTML documentation, etc. It's unfortunate to have to do this, but I think it is safe to do. mkaply: I can do this on OS/2 as well if you think it should be done there. The changes will be confined to nsURLHelperWin.cpp and nsURLHelperOS2.cpp is mostly a copy of nsURLHelperWin.cpp.
Assignee | ||
Comment 1•20 years ago
|
||
comments from andreas otte via email:
> Fine with me, but if we do it, that code (also looking for %5C) should
> be placed into the functions that convert file-urls into paths. They
> have no place in the url-parser.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8alpha2
Assignee | ||
Updated•20 years ago
|
Target Milestone: mozilla1.8alpha2 → mozilla1.8beta
Comment 2•20 years ago
|
||
*** Bug 252538 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 3•20 years ago
|
||
Assignee | ||
Comment 4•20 years ago
|
||
Comment on attachment 154704 [details] [diff] [review] v1 patch I noticed quite a lot of rough edges in the handling of non-ASCII file:// URLs. I doubt they work very well... I plan on filing some bugs on various issues that I spotted.
Attachment #154704 -
Flags: review?(cbiesinger)
Comment 5•20 years ago
|
||
Comment on attachment 154704 [details] [diff] [review] v1 patch base/src/nsURLHelper.cpp + for (const char *s = begin; *s; ++s) that assumes the string is null-terminated. couldn't this be a substring? base/src/nsURLHelper.h you should mention that aResultBuf will be unmodified if the url was already normalized and that the string should be empty initially.
Attachment #154704 -
Flags: review?(cbiesinger) → review+
Assignee | ||
Comment 6•20 years ago
|
||
> + for (const char *s = begin; *s; ++s) > > that assumes the string is null-terminated. couldn't this be a substring? yup.. good catch!! > you should mention that aResultBuf will be unmodified if the url was already > normalized and that the string should be empty initially. will do, thanks!
Assignee | ||
Updated•20 years ago
|
Whiteboard: [patch]
Assignee | ||
Comment 7•20 years ago
|
||
revised with correction to end-of-string determination.
Assignee | ||
Updated•20 years ago
|
Attachment #154704 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #155148 -
Flags: superreview?(bzbarsky)
Comment 8•20 years ago
|
||
Comment on attachment 155148 [details] [diff] [review] v1.1 patch >Index: base/src/nsURLHelper.h >+ * @returns false if aURL is already normalized. Otherwise, returns true. Make it clear that when aURL is already normalized aResultBuf will be left empty (or that its value shouldn't be relied on, or whatever)... sr=bzbarsky with that.
Attachment #155148 -
Flags: superreview?(bzbarsky) → superreview+
Assignee | ||
Comment 9•20 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 10•20 years ago
|
||
I'm getting the following error with my Win32/MinGW/cygwin build of Mozilla. Reopening bug. e:/mozilla/source/mozilla/netwerk/base/src/nsURLHelper.cpp: In function `PRBool net_NormalizeFileURL(const nsACString&, nsCString&)': e:/mozilla/source/mozilla/netwerk/base/src/nsURLHelper.cpp:602: error: name look up of `s' changed for new ISO `for' scoping e:/mozilla/source/mozilla/netwerk/base/src/nsURLHelper.cpp:591: error: using o bsolete binding at `s' make[5]: *** [nsURLHelper.o] Error 1 make[5]: Leaving directory `/cygdrive/e/mozilla/source/mozilla/netwerk/base/src' make[4]: *** [libs] Error 2 make[4]: Leaving directory `/cygdrive/e/mozilla/source/mozilla/netwerk/base' make[3]: *** [libs] Error 2 make[3]: Leaving directory `/cygdrive/e/mozilla/source/mozilla/netwerk' make[2]: *** [libs] Error 2 make[2]: Leaving directory `/cygdrive/e/mozilla/source/mozilla' make[1]: *** [alldep] Error 2 make[1]: Leaving directory `/cygdrive/e/mozilla/source/mozilla' make: *** [alldep] Error 2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 11•20 years ago
|
||
fix checked in for MingW bustage.
Comment 12•20 years ago
|
||
Thanks, that fixed by build problems. Resolving.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Comment 13•20 years ago
|
||
Comment on attachment 155148 [details] [diff] [review] v1.1 patch I want this in 1.7. And it really should have gone into Firefox 1.0. Once the FF branch opens for 1.0X stuff, we really should get this in. Ugly bug
Attachment #155148 -
Flags: approval1.7.x+
Attachment #155148 -
Flags: approval-aviary+
Comment 14•20 years ago
|
||
Comment on attachment 155148 [details] [diff] [review] v1.1 patch There is no post 1.0 aviary and I don't think this would be needed for Thunderbird - darin?
Attachment #155148 -
Flags: approval1.7.x+ → approval1.7.x-
Comment 15•20 years ago
|
||
Comment on attachment 155148 [details] [diff] [review] v1.1 patch There is no post 1.0 aviary and I don't think this would be needed for Thunderbird - darin?
Attachment #155148 -
Flags: approval1.7.x-
Attachment #155148 -
Flags: approval1.7.x+
Attachment #155148 -
Flags: approval-aviary-
Attachment #155148 -
Flags: approval-aviary+
Assignee | ||
Comment 16•20 years ago
|
||
yeah, i doubt thunderbird has any need for this patch.
Updated•20 years ago
|
Attachment #155148 -
Flags: approval1.7.6+
Attachment #155148 -
Flags: approval1.7.5-
Attachment #155148 -
Flags: approval1.7.5+
You need to log in
before you can comment on or make changes to this bug.
Description
•