249988 - Offline settings aren't saved.

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Julien ÉLIE]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1)
Build Identifier: 

If I try to change offline settings (in the File menu), the parameters I set 
are not saved (in fact, there is a shift).

Reproducible: Always
Steps to Reproduce:
1. File > Offline > Offline parameters
2. Put « no » for instance to « send the unsent mails when going online ».
3. Click « OK ».
4. Go again to these parameters.
Actual Results:  
There is « ask » for the parameter I set.

Expected Results:  
It would have saved « no ».

Sorry if it has already been submitted ; but I did not see it.
I am using Thunderbird 0.7.1.

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

The problem is based on the offline prefs-dialog re-organization:

Have a look into "pref-offline.xul" - after the re-organization 2 month ago:
    <radio value="1" label="&radioAutoSend;" 
accesskey="&radioAutoSend.accesskey;"/>
    <radio value="2" label="&radioNotSend;"   accesskey="&radioNotSend.accesskey;"/>
    <radio value="0" label="&radioAskUnsent;"
accesskey="&radioAskUnsent.accesskey;"/>

Don't know why, but the problem is solved, if we have the lines / radiobuttons
in the following (old) order:

    <radio value="0" label="&radioAskUnsent;"
accesskey="&radioAskUnsent.accesskey;"/>
    <radio value="1" label="&radioAutoSend;" 
accesskey="&radioAutoSend.accesskey;"/>
    <radio value="2" label="&radioNotSend;"   accesskey="&radioNotSend.accesskey;"/>

NOTE: this problem occurs on both (online/offline) settings.

A working pref-offline.xul is attached to this comment.

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: proposed patch

Comment 3

[Scott MacGregor]

Attachment: the fix

Comment 4

[Scott MacGregor]

Comment on attachment 155779 [details] [diff] [review]
the fix

Use getElementsByAttribute instead of assuming the radio element values were in
the same order as the radiogroup's childNodes array.

While I was at it, I fixed another problem in this dialog. 

offline.startup_state is set to "2" in thunderbird.js. According to
OfflineStartupState.js, a value of 2 means connect in online mode. But there
were only two elements in this radio group with values of 0 and 1. So the first
time you brought up this dialog, the offline.startup_state radio group would
always be uninitialized since there wasn't a value for "2". I added a new radio
with a value of 2 and text for start online.