250282 - Scrolling keys should scroll when Find Toolbar has focus

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, enhancement)

Description

[Jesse Ruderman]

The following keys scrolled the page with the old find-as-you-type.  They should
scroll the page when the Find Toolbar has focus.

    Down, Up (except on Mac?)
    Pgdn, Pgup (all platforms)

Home, End, Space, and Shift+Space should do their normal text-editing things,
though.

Making these keys scroll would conflict with adding autocomplete to the Find
Toolbar, but I don't think the Find Toolbar should have autocomplete.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

-> Find Toolbar component.

Comment 2

[Jeremy M. Dolan]

This is a major regression in find-as-you-type usability. 90% of the time after
I find the string I'm looking for, I want to scroll up and down to see the context.

Comment 3

[Michael Clackler]

Attachment: patch to fix

This patch allows the PageUp/Down and Up/Down arrows to scroll the page while
the findbar has focus.

This patch also fixes an unreported bug where the highlight is not working into
frames.

Comment 4

[Michael Clackler]

Comment on attachment 154928 [details] [diff] [review]
patch to fix

request review

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

please fix your indentation... the lines starting with "evt." are overly
indented (please turn OFF tabs in your editor when editing mozilla code!)

Comment 6

[Michael Clackler]

Attachment: patch v2

Same patch with tabs removed to correct comments by Ben.

Comment 7

[Blake Ross]

Comment on attachment 155037 [details] [diff] [review]
patch v2

I don't think this patch is good enough--what if the phrase is found in a
frame? Will this scroll the frame?

Comment 8

[Blake Ross]

This is not a 1.0 blocker. It's an RFE; this didn't work in the old find dialog
either.

Comment 9

[Jesse Ruderman]

True, but it's annoying because I keep forgetting to close the Find Toolbar
after using it.

Comment 10

[Jeremy M. Dolan]

> It's an RFE; this didn't work in the old find dialog either.

Scrolling did work fine, however, with the old Find-As-You-Type. (See comment
2). Ben had plused this; Renominating since the minusing comment doesn't seem to
address the regression vs. FAYT.

Comment 11

[Blake Ross]

As far as I can tell, scrolling up and down with the arrow keys works fine now
with FAYT ever since I fixed it to not actually focus the toolbar when using FAYT.

I'm starting to change my mind and think that getting this fix in is better than
nothing. Right now scrolling won't work on either framesets or normal pages.
Seems like a big improvement to just get it working on normal pages, at least,
especially given how uncommon framed pages are becoming.

Comment 12

[Blake Ross]

Okay, I went ahead and fixed this in the non-framed case. I believe that's
enough for 1.0.

Comment 13

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050621
Firefox/1.0+ ID:2005062110

with the new FAYT bar you can scroll as you wish
->INVALID ?

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Yes. Currently find toolbar doesn't have this problem.

-> FIXED