253359 - Artwork for RSS folders and posts

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[Scott MacGregor]

I don't know when we'll get new artwork for RSS accounts, folders and feed articles.

We are currently using the same icons used for mail accounts. 

I think the news artwork makes more sense for RSS accounts (at least for the
qute theme) as the pieces of that artwork map better into what it means to be an
RSS feed.

Comment 1

[Scott MacGregor]

Attachment: fix to use news icons for rss feeds

Comment 2

[Scott MacGregor]

Comment on attachment 154535 [details] [diff] [review]
fix to use news icons for rss feeds

David, what do you think of my changes to nsMsgDBView to  generate the right
CSS property in the thread pane for arbitrary server types. Instead of adding
an atom for news, I'm adding a generic message type atom which matches whatever
the server type is.

This allows us to have CSS which references 'rss' without actually having the
view code know anything about rss.

The only catch was the fact that nntp server types currently map to 'news' and
not 'nntp' so I had to special case that to match the old behavior.

Comment 3

[David :Bienvenu]

Comment on attachment 154535 [details] [diff] [review]
fix to use news icons for rss feeds

this could just be 

else 
  mMessageTypeAtom = do_GetAtom(mIsNews ? "news" : type.get()));

+    else if (mIsNews) // special case nntp --> news since we'll break themes
if we try to be consistent
+      mMessageTypeAtom = do_GetAtom("news");
+    else
+      mMessageTypeAtom = do_GetAtom(type.get());

Comment 4

[Scott MacGregor]

fixed branch and trunk