Closed
Bug 255326
Opened 20 years ago
Closed 20 years ago
commandglue.js method IsSpecialFolder always says sub-folders of inbox are "special"
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Bienvenu, Assigned: Bienvenu)
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file, 1 obsolete file)
13.88 KB,
patch
|
mscott
:
superreview+
|
Details | Diff | Splinter Review |
IsSpecialFolder() tells us that any sub-folder of the INBOX is an inbox folder, which means we never close the summary files for cyrus/courier servers, because we think they're all the INBOX (assuming you haven't set the online dir to INBOX.) IsSpecialFolder does this to detect if a folder is a sub-folder of the trash, but it shouldn't do it for the INBOX.
Assignee | ||
Comment 1•20 years ago
|
||
add a parameter to IsSpecialFolder, deep, that checks sub-folders, and change callers. All callers except for INBOX pass true for deep, currently, and we pass false for INBOX, so that we won't say sub-folders of the inbox are the inbox!
Assignee | ||
Updated•20 years ago
|
Attachment #155933 -
Flags: superreview?(mscott)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Summary: commandglue.js method IsSpecialFolder ialways says sub-folders of inbox are "special" → commandglue.js method IsSpecialFolder always says sub-folders of inbox are "special"
Assignee | ||
Comment 2•20 years ago
|
||
I've renamed the "deep" var to checkancestors, which is a more accurate name, and simplified the IsSpecialFolder method.
Assignee | ||
Updated•20 years ago
|
Attachment #155933 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #155933 -
Flags: superreview?(mscott)
Assignee | ||
Updated•20 years ago
|
Attachment #155936 -
Flags: superreview?(mscott)
Comment 3•20 years ago
|
||
Comment on attachment 155936 [details] [diff] [review] better fix you might need to change mail\searchBar.js too.
Attachment #155936 -
Flags: superreview?(mscott) → superreview+
Assignee | ||
Comment 4•20 years ago
|
||
thx, good catch, it was in my tree, but I pruned it out accidentally from the diffs file when editing out the non-relevant diffs...:-(
Assignee | ||
Comment 5•20 years ago
|
||
fix checked in.
Comment 6•20 years ago
|
||
It hardly seems worth having a deep parameter to IsSpecialFolder - just use msgFolder.flags & MSG_FOLDER_FLAG_INBOX (or whatever) instead.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•