256221 - crash running filter on an IMAP folder [@ nsImapMailFolder::MarkMessagesRead ]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Asa Dotzler [:asa]]

Maybe one of those once in a lifetime crashers, but I haven't crashed Tbird in
forever so I thought I'd get this on record. If there are no reproducible
reports in the next few weeks, I'll just mark this invalid or WFM. 

nsImapMailFolder::MarkMessagesRead[mailnews/imap/src/nsImapMailFolder.cpp,line1776]
nsMsgFilterAfterTheFact::ApplyFilter[mailnews/base/search/src/nsMsgFilterService.cpp,line595]
nsMsgFilterAfterTheFact::OnSearchDone[mailnews/base/search/src/nsMsgFilterService.cpp,line469]
nsMsgSearchSession::NotifyListenersDone[mailnews/base/search/src/nsMsgSearchSession.cpp,line594]
nsMsgSearchSession::OnStopRunningUrl[mailnews/base/search/src/nsMsgSearchSession.cpp,line383]
nsUrlListenerManager::BroadcastChange[mailnews/base/src/nsUrlListenerManager.cpp,line97]
nsUrlListenerManager::OnStopRunningUrl[mailnews/base/src/nsUrlListenerManager.cpp,line123]
nsImapMailFolder::SetUrlState[mailnews/imap/src/nsImapMailFolder.cpp,line5953]
XPTC_InvokeByIndex[xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,line102]
EventHandler[xpcom/proxy/src/nsProxyEvent.cpp,line545]
SHELL32.dll+0x4e0c24(0x778b0c24)
nsHTMLIFrameElement::EnsureFrameLoader[content/html/content/src/nsHTMLIFrameElement.cpp,line286]
0x8b084d01

Comment 1

[Adam Hauner]

There are 13 incidents, most with Thunderbird, one with M 1.7:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=nsImapMailFolder%3A%3AMarkMessagesRead

Comments:
Running message filters on a folder	
Running a message filter on my IMAP Trash folder, I think	
Manually ran filters from within a sub folder.	
I've chosen "run message filters" on a folder (IMAP) and clicked on some
different IMAP folder.	
Running a filter on an IMAP folder...	

Comment 2

[Asa Dotzler [:asa]]

Yes, that fits my usage pattern. I believe that this was running filters on a
folder. 

Comment 3

[David :Bienvenu]

simple null check should fix this, or a call to GetMsgDatabase().

Comment 4

[David :Bienvenu]

Attachment: proposed fix