258217 - Windows DDE code should extract application name from nsXREAppData

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Darin Fisher]

The Windows DDE code should extract the application's name from nsXREAppData. 
Currently, it inspects the current EXE's resource section for the application's
name.  This makes it difficult to override the application's name at runtime,
which is something XULRunner needs.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Very simple patch.

Comment 2

[Benjamin Smedberg]

Comment on attachment 158127 [details] [diff] [review]
v1 patch

0) This is currently differentiated between debug/not-debug. Do we care?
http://lxr.mozilla.org/mozilla/source/browser/app/splash.rc#51

1) fix OS/2 also:
http://lxr.mozilla.org/mozilla/source/toolkit/xre/nsNativeAppSupportOS2.cpp#758

2) remove the stringtable entries which are no longer needed:
http://lxr.mozilla.org/mozilla/search?string=dde_application_name

(everything except for xpfe/)

Comment 3

[Darin Fisher]

> 0) This is currently differentiated between debug/not-debug. Do we care?
> http://lxr.mozilla.org/mozilla/source/browser/app/splash.rc#51

Yeah, I thought about that too.. I think it probably isn't worth concerning
ourselves with that.  Folks can use MOZ_NO_REMOTE=1 or even -app if they care ;-)

Moreover, we don't make such a distinction for SeaMonkey today.


> 1) fix OS/2 also:

yup


> 2) remove the stringtable entries which are no longer needed:

right, i meant to include that in this patch :-/

Comment 4

[Darin Fisher]

Attachment: v1.1 patch - revised, final patch

Comment 5

[Darin Fisher]

fixed-on-trunk

Comment 6

[David G King]

Reopening as this breaks Win32/MingW/cygwin builds :-

e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp: In
constructor `Mutex::Mutex(const char*)':
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp:138:
 warning: converting of negative value `-0x000000001' to `DWORD'
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp: In
destructor `Mutex::~Mutex()':
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp:149:
 warning: unused variable 'rc'
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp: In
member function `void Mutex::Unlock()':
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp:177:
 warning: converting of negative value `-0x000000001' to `DWORD'
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp: In
member function `virtual nsresult nsNativeAppSupportWin::StartDDE()':
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp:727:
 error: invalid conversion from `const char* const' to `CHAR*'
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp: In
static member function `static void nsNativeAppSupportWin::ParseDDEArg(HSZ__*, i
nt, nsCString&)':
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp:1212
: warning: passing NULL used for non-pointer converting 4 of `DWORD DdeQueryStri
ngA(DWORD, HSZ__*, CHAR*, DWORD, int)'
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp: At
global scope:
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp:868:
 warning: 'nsCString uTypeDesc(UINT)' defined but not used
e:/mozilla/source/thunderbird/mozilla/toolkit/xre/nsNativeAppSupportWin.cpp:871:
 warning: 'nsCString hszValue(DWORD, HSZ__*)' defined but not used
make[4]: *** [nsNativeAppSupportWin.o] Error 1
make[4]: Leaving directory `/cygdrive/e/mozilla/source/thunderbird/mozilla/toolk
it/xre'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/cygdrive/e/mozilla/source/thunderbird/mozilla/toolk
it'
make[2]: *** [libs] Error 2
make[2]: Leaving directory `/cygdrive/e/mozilla/source/thunderbird/mozilla'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/e/mozilla/source/thunderbird/mozilla'
make: *** [alldep] Error 2

Comment 7

[Darin Fisher]

fix for MingW bustage checked in.  where's the MingW firefox tinderbox?

marking FIXED again.

Comment 8

[David G King]

All working again....thanks.

Comment 9

[Andy Willis (abwillis)]

This patch was never checked into the Aviary Branch for OS/2.  I found while
building Firefox and Sunbird on OS/2 from the trunk:
E:/cvs/work/mozilla/toolkit/xre/nsNativeAppSupportOS2.cpp: In member function `
   virtual nsresult nsNativeAppSupportOS2::StartDDE()':
E:/cvs/work/mozilla/toolkit/xre/nsNativeAppSupportOS2.cpp:882: error: invalid
   conversion from `const char* const' to `char*'
make.exe[1]: *** [nsNativeAppSupportOS2.o] Error 1
make.exe[1]: Leaving directory `E:/cvs/work/mozilla/ffobj/toolkit/xre'

NS_ENSURE_TRUE( ( mApplication = WinDdeCreateStringHandle( gAppData->appName,
CP_WINANSI ) ) && InitTopicStrings(),
                    NS_ERROR_FAILURE );

WinDdeCreateStringHandle is expecting a char* but is getting a const char is
what I think the problem is.  I don't know enough C to get further than that.
Andy

Comment 10

[Andy Willis (abwillis)]

Ok, I found the fix for mingw fixes the issue on OS/2 as well.