Closed Bug 26109 Opened 25 years ago Closed 24 years ago

need to prevent HINT_CONTENT from doing a restyle

Categories

(Core :: XUL, defect, P2)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: waterson, Assigned: hyatt)

Details

(Keywords: perf) 

Implement ".value" API for titledbuttons. Using attributes to communicate 
changes in value forces the style system to re-resolve style on the 
titledbutton.

Profiling page load showed style re-resolution because of attribute change to 
account for approximately 5% of the overall load time.
Status: NEW → ASSIGNED
Keywords: perf
Priority: P3 → P2
Target Milestone: M14
this will make mailnews happy too.
hyatt: you're already doing this.
Assignee: waterson → hyatt
Status: ASSIGNED → NEW
PDT: I'm marking this beta1. hyatt already has the changes in his tree, and this
will improve page load times in seamonkey by about 5%.
Keywords: beta1
You're still doing the style hint of none bit, right?  All I'm doing is adding 
the properties (which set attributes behind the scenes).
Status: NEW → ASSIGNED
Also, isn't it the scrollbar and progressmeter that really need this done?

I tried changing GetMappedAttributeImpact() to return NS_STYLE_HINT_NONE for 
<titledbutton value="...">. This caused the titledbutton to *not* render. So I 
decided it wasn't a good idea ;-).

I'm pretty sure that <titledbutton value="..."> is the primary offender, but 
I'll verify that.
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]
Ok, I checked in some property APIs for various XUL widgets tonight, but this 
bug still isn't ready to be marked fixed. 

Now what's needed is to make STYLE_HINT_NONE really work.  I have a patch for 
this.  I'm running it by troy, vidur, and pierre to see if it's acceptable.

That's where this bug is.
Whiteboard: [PDT+] → [PDT+] Patch in hand. Needs discussion with Gecko engineers.
Ok, current thinking is to make a new hint or patch HINT_CONTENT to do what we 
want instead.
Whiteboard: [PDT+] Patch in hand. Needs discussion with Gecko engineers. → [PDT+] Patch in hand. Waiting on response from Gecko engineers.
Talked to jar.  This is not a requirement for beta1.  Removing PDT+ designation 
and moving to M15.
Keywords: beta1
Whiteboard: [PDT+] Patch in hand. Waiting on response from Gecko engineers. → Patch in hand. Waiting on response from Gecko engineers.
Target Milestone: M14 → M15
Summary: implement <titledbutton> property API → need to prevent HINT_CONTENT from doing a restyle
Whiteboard: Patch in hand. Waiting on response from Gecko engineers.
Target Milestone: M15 → M17
Mass moving M17 bugs to M18
Target Milestone: M17 → M18
spam, open xptoolkit qa contact moving over to jrgm
QA Contact: paulmac → jrgm
shaver's changes take care of this.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.