262008 - add a close icon inside the quick search box

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

the button would only be visible when there is text inside the quick search field.

Pressing it would clear the view.

We could use the close tab icon from firefox.

Ben suggested this.

Comment 1

[Scott MacGregor]

*** Bug 255643 has been marked as a duplicate of this bug. ***

Comment 2

[sairuh (rarely reading bugmail)]

would this button be accessible from the keyboard? from what I recall the Clear
button (at least in seamonkey) had an accesskey and was part of the tabbing
cycle in the 3pane window.

Comment 3

[Scott MacGregor]

Attachment: first pass at a fix

this works pretty well. There are a couple remaining focus issues I need to
work out. I'd also like to move more of the focus logic into the XBL widget
instead of SearchBar.js.

Comment 4

[Scott MacGregor]

Attachment: screen shot with the close button visible (it is hidden when there is no text)

Comment 5

[Lorenzo Colitti]

Hmm, from the screenshot it looks like it's small and so hard to get to easily...

Will there be a keyboard shortcut (Esc?)?

Comment 6

[Scott MacGregor]

Attachment: updated fix with more focus improvements

piling on the focus hacks....

I suspect this whole file is going to need to be re-designed after 1.0
otherwise maintenance is going to be a pain.

Comment 7

[Scott MacGregor]

Attachment: simpler fix..move most of the focus controls for the close button into xbl

This moves most of the visibility/focus logic for the close button into the xbl
binding instead of in searchBar.js.

Comment 8

[Scott MacGregor]

fixed on the branch and the trunk.

There are still some problems with this on OS X that I've asked Kevin to help me
out on. For now, I'm not showing the icon on OS X until I can work out the theme
issue.

Comment 9

[sairuh (rarely reading bugmail)]

(In reply to comment #5)
> Will there be a keyboard shortcut (Esc?)?

Scott reminded me that Esc stops the throbber in tbird, so that shortcut
wouldn't work for clearing the quicksearch field. however, there are a couple of
keyboard workarounds:

a. the quicksearch field is in the tabbing cycle, so when you tab to it, its
contents will be selected (if anything's there). then you could hit Delete to
clear it.

b. Ctrl/Cmd+K will move focus to the quicksearch field and select its contents.
then hitting Delete would clear it.

Comment 10

[Lorenzo Colitti]

(In reply to comment #9)
> > Will there be a keyboard shortcut (Esc?)?
> 
> Scott reminded me that Esc stops the throbber in tbird, so that shortcut
> wouldn't work for clearing the quicksearch field.

So? Esc stops the throbber in Firefox too...
In fact, Esc in firefox has many functions: it stops image animation, stops page
loading and clears the find bar. It possibly does other things too. :)

So if consistency is what we want, then using Esc shouldn't be a problem...

Comment 11

[Kevin Gerich]

Checked in theme fixes for search boxes in main window, address book and
contacts pane on branch. I'll put it on the trunk when I manage to get a trunk
build working

Comment 12

[Guy Harris]

Is that "fixed in 0.9" or "will be fixed in 1.0"?  Sometimes I see the close (X) in OS X, and other times I 
don't, although, in 0.9, I can clear the field and search again in order to get back to a full display, so at 
least in 0.9 there's a workaround.

Comment 13

[Mike Cowperthwaite]

(In reply to comment #12)
> Is that "fixed in 0.9" or "will be fixed in 1.0"?  

"Fixed" in this case means "implemented."


> Sometimes I see the close (X) in OS X, and other times I don't
>[...]
> at least in 0.9 there's a workaround.

As opposed to which build?  0.8 doesn't offer the close button at all; if you 
mean you're seeing it working consistently in 0.9+ nightlies, then whatever 
problem you've encountered has been fixed.  But if you're seeing inconsistent 
behavior in the appearance of the [X] icon in the close box, in the latest 
version you're running, open a new bug for that.

FWIW, the icon is appearing, and operating, quite nicely for me with 0.9 under 
Win2K.

Comment 14

[Guy Harris]

> > Sometimes I see the close (X) in OS X, and other times I don't
> >[...]
> > at least in 0.9 there's a workaround.

> As opposed to which build?

As opposed to 0.8, where, as I remember, I couldn't even clear the field to get all the messages to be 
displayed again.  (There was a workaround in 0.8, actually, but it was a pain - I could go to another 
mailbox and return to the mailbox I was looking at.)

> But if you're seeing inconsistent 
> behavior in the appearance of the [X] icon in the close box, in the latest 
> version you're running,

I'm occasionally seeing the [X] icon not work, so...

> open a new bug for that.

Will do.