265014 - Allow creation of virtual folders that search offline instead of online

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

We should have a checkbox in the virtual folder UI that allows you to specify if
the saved search should just search locally (results in faster loading but less
accurate results for online folders) or online (most accurate results but longer
loading times).

Comment 1

[Scott MacGregor]

Attachment: the fix

Comment 2

[Scott MacGregor]

Comment on attachment 162554 [details] [diff] [review]
the fix

David, is this the kind of thing you had in mind? Note the changes to
nMsgAccountManager to ensure that the new attribute gets written out to
virtualFolders.dat. I didn't bump the version number for this since I didn't
think many folks would be taking advantage of the VFolders yet. And if they
did, this attribute would just be ignored by older builds when they parse the
file. 

Also the wordage for the check box needs to be improved. Should we be fancy and
disable the checkbox if you choose folders that aren't online folders to
search? i.e. RSS & local/pop folders?

Comment 3

[Scott MacGregor]

Attachment: screen shot showing the new checkbox

Comment 4

[David :Bienvenu]

Comment on attachment 162554 [details] [diff] [review]
the fix

that looks good - it's fine to ignore that setting for existing VF's, I think. 

slightly better wording might be :

(Gives up-to-date results for IMAP and News folders but increases time to open
the folder)

I think disabling that box for pop3 and other non-online servers would help
avoid confusion for pop3 users...

Comment 5

[Scott MacGregor]

Attachment: updated fix to disable the checkbox for local folders

Comment 6

[Scott MacGregor]

Comment on attachment 162600 [details] [diff] [review]
updated fix to disable the checkbox for local folders

How about this version David. Same patch except we disable/enable the checkbox
appropriately. And I changed the wording to match your suggestion.

Comment 7

[Scott MacGregor]

fixed branch and trunk

Comment 8

[Andrew Schultz]

The most recent checkin hosed the mail window.

JavaScript error: chrome://messenger/content/commandglue.js, line 1057: missing
{ before function body

there's an extra ')' before the {

Comment 9

[Scott MacGregor]

I can't seem to reproduce that JS error. The dialog is working for me. I'll look
at the code again.

Comment 10

[Marcia Knous [:marcia]]

I am not able to reproduce the error referenced in Comment 8 either.