Closed
Bug 266289
Opened 20 years ago
Closed 20 years ago
nsIAlertsService should use AString instead of wstring
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8alpha6
People
(Reporter: csthomas, Assigned: csthomas)
Details
Attachments
(1 file)
8.24 KB,
patch
|
mscott
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•20 years ago
|
Assignee: general → cst
Assignee | ||
Updated•20 years ago
|
Whiteboard: active
Updated•20 years ago
|
Product: Browser → Seamonkey
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #167950 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #167950 -
Flags: review?(scott)
Assignee | ||
Updated•20 years ago
|
Whiteboard: active → active, r?
Assignee | ||
Updated•20 years ago
|
Attachment #167950 -
Flags: review?(scott) → review?(mscott)
Assignee | ||
Updated•20 years ago
|
Attachment #167950 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview?(jag)
Comment 2•20 years ago
|
||
Do we use nsAString for URIs? Or nsACString? Or should we just switch to a nsIURI there? Or would that be overkill?
Comment 3•20 years ago
|
||
It gets passed to JavaScript to set as an attribute on a XUL element. (Ideally it would be the class attribute rather than the src, but...) I believe JavaScript would prefer to find a UTF-16 string here.
Updated•20 years ago
|
Attachment #167950 -
Flags: review?(mscott) → review+
Assignee | ||
Updated•20 years ago
|
Target Milestone: --- → mozilla1.8alpha6
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Comment 4•20 years ago
|
||
Comment on attachment 167950 [details] [diff] [review] Patch The very long line you made in nsMessengerWinIntegration looks as if it should be rewrapped.
Attachment #167950 -
Flags: superreview?(jag) → superreview+
Assignee | ||
Updated•20 years ago
|
Whiteboard: active, r? → checkin
Assignee | ||
Updated•20 years ago
|
Whiteboard: checkin → checkin [re-wrap before checkin]
Assignee | ||
Comment 5•20 years ago
|
||
checked in... (In reply to comment #4) > (From update of attachment 167950 [details] [diff] [review] [edit]) > The very long line you made in nsMessengerWinIntegration looks as if it should > be rewrapped. ...and checked in again (sorry).
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: checkin [re-wrap before checkin]
You need to log in
before you can comment on or make changes to this bug.
Description
•