Closed
Bug 272167
Opened 20 years ago
Closed 19 years ago
nsIWindowsRegistry::getRegistryEntry does not support non-latin1 keys/values
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: jshin1987)
References
()
Details
(Keywords: intl)
Attachments
(1 file)
5.63 KB,
patch
|
Biesinger
:
review+
darin.moz
:
superreview+
shaver
:
approval1.8b3+
|
Details | Diff | Splinter Review |
[filing here for lack of a better component] seamonkey version of bug Bug 272166 231 string getRegistryEntry( in long aHKeyConstant, in string aSubKeyName, in string aValueName ); This means that only latin1 is supported. Worse, on a non-latin1 (guess that's really a non-windows1252) system, the characters will be interpreted as latin1, likely leading to garbage for non-ascii characters. this should use wstring or AString in the IDL.
Assignee | ||
Comment 1•19 years ago
|
||
there's no consumer. we can just rid of it.
Assignee: guifeatures → jshin1987
Status: NEW → ASSIGNED
Assignee | ||
Updated•19 years ago
|
Attachment #184219 -
Flags: superreview?(darin)
Attachment #184219 -
Flags: review?(cbiesinger)
Comment 2•19 years ago
|
||
Comment on attachment 184219 [details] [diff] [review] patch to get rid of it >-#define NS_IWINDOWSHOOKS_CONTRACTID "@mozilla.org/winhooks;1" >-#define NS_IWINDOWSHOOKS_CLASSNAME "Mozilla Windows Integration Hooks" I don't think you meant to delete these, did you?
Assignee | ||
Comment 3•19 years ago
|
||
You're right. I mistakendly thought they're for nsIWindowsRegistry. Thanks for catching it.
Reporter | ||
Comment 4•19 years ago
|
||
Comment on attachment 184219 [details] [diff] [review] patch to get rid of it I'm not sure that we should remove this. extensions may well be using it, and in fact are (see google results for nsiwindowsregistry) maybe it's ok now that we have bug 292981's nsIWindowsRegKey...
Comment 5•19 years ago
|
||
Comment on attachment 184219 [details] [diff] [review] patch to get rid of it I say remove it, and encourage extensions to use the new interface. The old interface is not unicode-safe.
Attachment #184219 -
Flags: superreview?(darin) → superreview+
Reporter | ||
Comment 6•19 years ago
|
||
Comment on attachment 184219 [details] [diff] [review] patch to get rid of it ok, then. r=biesi with what neil said.
Attachment #184219 -
Flags: review?(cbiesinger) → review+
Assignee | ||
Comment 7•19 years ago
|
||
Comment on attachment 184219 [details] [diff] [review] patch to get rid of it thanks for r/sr. asking for a of trunk landing. this is a low risk patch except that a couple of extensions use this interface. We have to release-note this (the draft is available in bug 272166.) I'll modify it for mozilla suite (there's a little difference).
Attachment #184219 -
Flags: approval1.8b3?
Comment on attachment 184219 [details] [diff] [review] patch to get rid of it a=shaver
Attachment #184219 -
Flags: approval1.8b3? → approval1.8b3+
Assignee | ||
Comment 9•19 years ago
|
||
fix just landed
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•