272167 - nsIWindowsRegistry::getRegistryEntry does not support non-latin1 keys/values

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

[filing here for lack of a better component]

seamonkey version of bug Bug 272166

231                    string getRegistryEntry( in long aHKeyConstant, in string
aSubKeyName, in string aValueName );

This means that only latin1 is supported. Worse, on a non-latin1 (guess that's
really a non-windows1252) system, the characters will be interpreted as latin1,
likely leading to garbage for non-ascii characters.

this should use wstring or AString in the IDL.

Comment 1

[Jungshik Shin]

Attachment: patch to get rid of it

there's no consumer. we can just rid of it.

Comment 2

[[e-mail]]

Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

>-#define NS_IWINDOWSHOOKS_CONTRACTID    "@mozilla.org/winhooks;1"
>-#define NS_IWINDOWSHOOKS_CLASSNAME "Mozilla Windows Integration Hooks"
I don't think you meant to delete these, did you?

Comment 3

[Jungshik Shin]

You're right. I mistakendly thought they're for nsIWindowsRegistry. Thanks for
catching it.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

I'm not sure that we should remove this. extensions may well be using it, and
in fact are (see google results for nsiwindowsregistry)

maybe it's ok now that we have bug 292981's nsIWindowsRegKey...

Comment 5

[Darin Fisher]

Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

I say remove it, and encourage extensions to use the new interface.  The old
interface is not unicode-safe.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

ok, then. r=biesi with what neil said.

Comment 7

[Jungshik Shin]

Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

thanks for r/sr.

asking for a of trunk landing. this is a low risk patch except that a couple of
extensions use this interface. We have to release-note this (the draft is
available in bug 272166.) I'll modify it for mozilla suite (there's a little
difference).

Comment 8

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 184219 [details] [diff] [review]
patch to get rid of it 

a=shaver

Comment 9

[Jungshik Shin]

fix just landed