Closed Bug 274786 Opened 20 years ago Closed 20 years ago

We lose a final <, </, or <!

Categories

(Core :: DOM: HTML Parser, defect)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

patch v2
5.27 KB, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review 
Currently if a document ends with a <, </, or <!, we lose that data. IE consumes
it as text and so should we if for no other reason than because it's technically
a view-source munging bug. The URL field contains a testcase.
Attached patch Easy patch (obsolete) — — Splinter Review 
This patch is pretty straightforward, so looking for r+sr. The SetPosition()s
are necessary because if we don't do that, we end up losing the <.
Attachment #168788 - Flags: superreview?(jst)
Attachment #168788 - Flags: review?(jst)
Status: NEW → ASSIGNED
Comment on attachment 168788 [details] [diff] [review]
Easy patch

This is too easy... New patch coming up soon.
Attachment #168788 - Attachment is obsolete: true
Attachment #168788 - Flags: superreview?(jst)
Attachment #168788 - Flags: review?(jst)
Attached patch patch v2 — — Splinter Review 
This is a better approach and I think the other patch actually had a couple of
bugs...
Attachment #168883 - Flags: review?(jst)
Comment on attachment 168883 [details] [diff] [review]
patch v2

r+sr=jst
Attachment #168883 - Flags: superreview+
Attachment #168883 - Flags: review?(jst)
Attachment #168883 - Flags: review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: