Closed Bug 275996 Opened 20 years ago Closed 20 years ago

[FIX]Can not open new tab.("Open a new tab" button on personal toolbar)

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
x86
Windows XP
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta1

People

(Reporter: baffclan, Assigned: bzbarsky)

Details

(Whiteboard: regression?)

Attachments

(1 file)

Patch
1.43 KB, patch
timeless
: review+
neil
: superreview+
Details | Diff | Splinter Review 
Can not open new tab.
2004122506-trunk/WinXP

1. Open "about:config".
2. Print Preview "about:config".
3. Open dialog "Print Preview Error".
4. If you click "Open a new tab" button on personal toolbar, 
   can not popen new tab.
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20041203
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB2749406G

Also crashing with yesterdays nightly, but talkbacks have offset only, no
symbols nor link to the code:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=2749341
 
I´m on 800x600, and Print-Preview shows a set of scrollbars, non-working, but
the scrollbar of about:config in the printing area is working
Severity: normal → critical
Keywords: crash
Whiteboard: TB2749406G
Incident ID: 2749406
Stack Signature	nsBoxObject::GetFrame 8c139eb2
Product ID	MozillaTrunk
Build ID	2004120304
Trigger Time	2004-12-25 20:28:13.0
Platform	Win32
Operating System	Windows 98 4.10 build 67766222
Module	GKLAYOUT.DLL + (0005bf15)
URL visited	https://bugzilla.mozilla.org/attachment.cgi?id=168505&action=view
User Comments	
Since Last Crash	328 sec
Total Uptime	29704 sec
Trigger Reason	Access violation
Source File, Line No.
c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/nsBoxObject.cpp,
line 169
Stack Trace 	
nsBoxObject::GetFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/nsBoxObject.cpp,
line 169]
nsTreeBoxObject::GetTreeBody 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/tree/src/nsTreeBoxObject.cpp,
line 155]
nsTreeBoxObject::GetColumns 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/tree/src/nsTreeBoxObject.cpp,
line 231]
XPTC_InvokeByIndex 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,
line 102]
XPCWrappedNative::CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 2036]
XPC_WN_GetterSetter 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1320]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1288]
js_InternalInvoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1384]
js_InternalGetOrSet 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1427]
js_GetProperty 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsobj.c, line
2691]
js_Interpret 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 3447]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1307]
js_InternalInvoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1384]
js_InternalGetOrSet 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1427]
js_GetProperty 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsobj.c, line
2691]
JS_GetProperty 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsapi.c, line
2593]
nsXPCWrappedJSClass::CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappedjsclass.cpp,
line 1319]
nsXPCWrappedJS::CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappedjs.cpp,
line 450]
PrepareAndDispatch 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp,
line 119]
SharedStub 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcstubs.cpp,
line 147]
nsTreeColFrame::EnsureColumns 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/tree/src/nsTreeColFrame.cpp,
line 235]
nsTreeColFrame::Init 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/xul/base/src/tree/src/nsTreeColFrame.cpp,
line 114]
nsCSSFrameConstructor::InitAndRestoreFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 6727]
nsCSSFrameConstructor::ConstructXULFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 5920]
nsCSSFrameConstructor::ConstructFrameInternal 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 7585]
nsCSSFrameConstructor::ConstructFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 7469]
nsCSSFrameConstructor::ProcessChildren 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 11709]
nsCSSFrameConstructor::ConstructXULFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 6001]
nsCSSFrameConstructor::ConstructFrameInternal 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 7585]
nsCSSFrameConstructor::ConstructFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 7469]
nsCSSFrameConstructor::ProcessChildren 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 11709]
nsCSSFrameConstructor::ConstructXULFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 6001]
nsCSSFrameConstructor::ConstructFrameInternal 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 7585]
nsCSSFrameConstructor::ConstructFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 7469]
nsCSSFrameConstructor::ProcessChildren 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 11709]
nsCSSFrameConstructor::ConstructDocElementFrame 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 4039]
nsCSSFrameConstructor::ContentInserted 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/style/src/nsCSSFrameConstructor.cpp,
line 8998]
PresShell::InitialReflow 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/layout/html/base/src/nsPresShell.cpp,
line 2721]
nsPrintEngine::ReflowPrintObject 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsPrintEngine.cpp,
line 2800]
nsPrintEngine::ReflowDocList 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsPrintEngine.cpp,
line 2532]
nsPrintEngine::SetupToPrintContent 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsPrintEngine.cpp,
line 2342]
nsPrintEngine::DocumentReadyForPrinting 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsPrintEngine.cpp,
line 2156]
nsPrintEngine::FinishPrintPreview 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsPrintEngine.cpp,
line 4477]
nsPrintEngine::PrintPreview 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsPrintEngine.cpp,
line 1244]
DocumentViewerImpl::PrintPreview 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/content/base/src/nsDocumentViewer.cpp,
line 3148]
XPTC_InvokeByIndex 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp,
line 102]
XPCWrappedNative::CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,
line 2036]
XPC_WN_CallMethod 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/xpconnect/src/xpcwrappednativejsops.cpp,
line 1288]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1288]
js_Interpret 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 3621]
js_Invoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1307]
js_InternalInvoke 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsinterp.c,
line 1384]
JS_CallFunctionValue 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/js/src/jsapi.c, line
3769]
nsJSContext::CallEventHandler 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/dom/src/base/nsJSEnvironment.cpp,
line 1346]
GlobalWindowImpl::RunTimeout 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/dom/src/base/nsGlobalWindow.cpp,
line 5042]
GlobalWindowImpl::TimerCallback 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/dom/src/base/nsGlobalWindow.cpp,
line 5403]
nsTimerImpl::Fire 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/threads/nsTimerImpl.cpp,
line 384]
nsAppShell::Run 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/widget/src/windows/nsAppShell.cpp,
line 142]
nsAppStartup::Run 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/components/startup/src/nsAppStartup.cpp,
line 216]
main1 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1330]
main 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1801]
WinMain 
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpfe/bootstrap/nsAppRunner.cpp,
line 1827]
WinMainCRTStartup()
KERNEL32.DLL + 0x1b537 (0xbff8b537)
Assignee: general → nobody
Component: General → XP Toolkit/Widgets: XUL
Product: Mozilla Application Suite → Core
QA Contact: general
Summary: Can not open new tab.("Open a new tab" button on personal toolbar) → Can not open new tab.("Open a new tab" button on personal toolbar) [@ nsBoxObject::GetFrame]
Version: unspecified → Trunk
(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20041203
Try a latest trunk.(see Bug 240490)

This Problem have not crash.
Severity: critical → normal
Keywords: crash
Whiteboard: TB2749406G
The crashes seen in comment 1 using MozillaTrunk Build ID 2004122405 and earlier
and Firefox are fixed by 2004-12-24 14:27 check-in for 
Bug 240490 M17x FF10PR1 crash after closing Print Preview of XUL page

WFM Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20041224 Firefox/1.0+
Trying to print preview about:config I get a PrintPreviewError message.
After closing the message, I can open new tabs using double-click on Tabbar,
Ctrl+T or File->NewTab


CONFIRMING Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a6) Gecko/20041225

Trying to print preview about:config I get a PrintPreviewError message.
After closing the message, I cannot open new tabs using click on icon in Tabbar,
Ctrl+T or File->NewTab, I can however open new tabs with right-click on links
(Open in new tab).
I can create a new window, and open new tabs there, but not in the old window,
even after about:config was closed.
Summary: Can not open new tab.("Open a new tab" button on personal toolbar) [@ nsBoxObject::GetFrame] → Can not open new tab.("Open a new tab" button on personal toolbar)
Whiteboard: regression?
Are there errors in the JS console when you try to open the new tabs?
(In reply to comment #5)
> Are there errors in the JS console when you try to open the new tabs?

no errors seen in JS console.
Seems the print-preview error blocks the creating of tabs,
it is restored after doing a print-preview without error.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050122

1. open JS-console
2. open about:config in a tab
3. open about: in another tab
4. print-preview about:config, close error message (Can´t be printed)
No error seen in JS-console, no way to create a new tab besides right-clicking
on a link (Open in new tab)
5. print-preview about:, close print-preview
now creation of tabs is working again normally.
Attached patch Patch — — Splinter Review 
Don't flag ourselves as previewing unless we actually are.
Assignee: nobody → bzbarsky
Status: UNCONFIRMED → ASSIGNED
Attachment #172464 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #172464 - Flags: review?(neil.parkwaycc.co.uk)
Priority: -- → P3
Summary: Can not open new tab.("Open a new tab" button on personal toolbar) → [FIX]Can not open new tab.("Open a new tab" button on personal toolbar)
Target Milestone: --- → mozilla1.8beta
Attachment #172464 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #172464 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
I cannot reproduce 2005012706-trunk/WinXP.
Thanks for fixing this.
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.widgets
Can not open new tab.("Open a new tab" button on personal toolbar)

OS: Windows 7
Firefox 12.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: