276278 - [BeOS] Dropdown boxes are dislocated

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect, P1)

Description

[Niels Reedijk]

Whenever you select dropdown boxes or menus, they are in the wrong location. It
seems that the drawing functions are fed absolute screen locations, while they
are interpreted as local co-ordinates.

Comment 1

[Niels Reedijk]

*** Bug 276878 has been marked as a duplicate of this bug. ***

Comment 2

[Niels Reedijk]

Attachment: The fix as proposed by fyysik

From the weblog by sergei_d:
"Shortly. Before we handled Pop-Up window coordinates in Move/Resize methods in
quite special manner, converting it from coorinates, provided by Mozilla to
screen coodrinates:
BPoint p = mBorderlessParent->ConvertToScreen(BPoint(aX,aY));
aX = (nscoord)p.x;
aY = (nscoord)p.y;

It seems that now Mozilla view manager handles it by self, so that part seems
unnecessary. And with removing this special case:
if (mWindowType == eWindowType_popup && mBorderlessParent)
from nsresult nsWindow::Move(PRInt32 aX, PRInt32 aY)
you will get proper results."

Comment 3

[Sergei Dolgov]

Comment on attachment 170529 [details] [diff] [review]
The fix as proposed by fyysik

r=[e-mail]
Pure port-patch, no sr required

Comment 4

[Niels Reedijk]

Committed by timeless.