277543 - Add default handling for xforms-focus

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

*** Bug 279179 has been marked as a duplicate of this bug. ***

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

This doesn't support repeat yet. I think it can be done after Bug 278209.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 172028 [details] [diff] [review]
v1

this doesn't handle
http://www.w3.org/TR/xforms/index-all.html#model-prop-relevant	properly.

Comment 4

[aaronr]

Comment on attachment 172028 [details] [diff] [review]
v1

yep, that is exactly how I was thinking to do it.  -'ing to allow smaug chance
to include two exceptional circumstances we found in the spec (handling focus
w.r.t. group and non-relevant controls).

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Comment 6

[aaronr]

Comment on attachment 172115 [details] [diff] [review]
v2

Looks ok to me.  Good job!
r=aaronr

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 172115 [details] [diff] [review]
v2

>@@ -211,12 +216,54 @@ nsXFormsGroupElement::Refresh()
>   result->GetSingleNodeValue(getter_AddRefs(mBoundNode));
>   NS_ENSURE_STATE(mBoundNode);
>   
>   return NS_OK;
> }
> 
>+PRBool
>+nsXFormsGroupElement::TryFocusChildControl(nsIDOMNode* aParent)
>+{
>+  if (!aParent)
>+    return PR_FALSE;
>+
>+  nsCOMPtr<nsIDOMNodeList> children;
>+  nsresult rv = aParent->GetChildNodes(getter_AddRefs(children));
>+  if (NS_FAILED(rv))
>+    return PR_FALSE;
>+
>+  PRUint32 childCount = 0;
>+  children->GetLength(&childCount);
>+  nsCOMPtr<nsIDOMNode> child;
>+
>+  for (PRUint32 i = 0; i < childCount; ++i) {

Hm, should this use the navIndex as described in 4.3.1?

>--- nsXFormsInputElement.cpp	19 Jan 2005 16:05:31 -0000	1.19
>+++ nsXFormsInputElement.cpp	22 Jan 2005 19:36:57 -0000
>@@ -339,12 +340,35 @@ nsXFormsInputElement::Refresh()
>     input->SetReadOnly(readonly);
>   }
> 
>   return NS_OK;
> }
> 
>+NS_IMETHODIMP
>+nsXFormsInputElement::TryFocus(PRBool* aOK)
>+{
>+  *aOK = PR_FALSE;
>+  if (GetRelevantState()) {
>+    nsresult rv = NS_ERROR_FAILURE;
>+    if (mType == eType_TextArea) {
>+      nsCOMPtr<nsIDOMHTMLTextAreaElement> textArea = do_QueryInterface(mControl);
>+      if (textArea)
>+        rv = textArea->Focus();
>+      
>+    } else {
>+      nsCOMPtr<nsIDOMHTMLInputElement> input = do_QueryInterface(mControl);
>+      if (input)
>+        rv = input->Focus();
>+    }
>+

Slightly easier:

nsCOMPtr<nsIDOMNSHTMLElement> element = do_QueryInterface(mControl);
element->Focus();

This handles both control types.  You could add
nsXFormsUtils::FocusControl(nsIDOMElemnet *aElement) to make things more
compact, too.

Comment 8

[aaronr]

I read navIndex in 4.3.1 as being something that is used by the host language
(XHTML2, SVG).  We could use an attribute like navIndex, but since it isn't part
of the spec, I don't know if the other XForms processors would honor it.  And of
course strictly honoring navIndex values, we'd have to worry about tab
navigation jumping over HTML elements that might be intermingled in the document
and basically preventing them from focusing.  These are the kinds of things that
are worrying me about how to generate the DOMFocusOut and DOMFocusIn events, too.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: doesn't support navIndex.

This doesn't support navIndex. If we want to support that, it should be done in
a
separate bug I think.
btw, navIndex is not mentioned in XForms schema.

Comment 10

[Allan Beaufour]

(In reply to comment #9)
> Created an attachment (id=172477) [edit]

How about having a nsIDOMNSHTMLElement* on nsXFormsControlStub, and then having
a common TryFocus() function there? Most controls would just need to set the
pointer at OnCreated() to whatever control should get focus.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

This has been checked in.