278039 - Add a11y description for XUL column

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Louie Zhao]

Steps to Reproduce:
1. Start GOK and launch Mozilla.
2. Go to File->Tools-Form Manager->Edit Form Info.
3. GOK UI Grab the Form Manger Editor dialog.

Bug Observation:
It is empty for the UI Grab element of the Category.

Comment 1

[Louie Zhao]

Attachment: patch v1

Comment 2

[Philip K. Warren]

Comment on attachment 170995 [details] [diff] [review]
patch v1

>Index: accessible/src/atk/nsMaiInterfaceTable.h
>===================================================================
>RCS file: /cvsroot/mozilla/accessible/src/atk/nsMaiInterfaceTable.h,v
>retrieving revision 1.1
>diff -p -u -5 -r1.1 nsMaiInterfaceTable.h
>--- accessible/src/atk/nsMaiInterfaceTable.h	6 May 2003 02:23:46 -0000	1.1
>+++ accessible/src/atk/nsMaiInterfaceTable.h	12 Jan 2005 05:35:40 -0000
>@@ -53,24 +53,24 @@ public:
...
>     void SetColumnDescription(nsAString &aString) {
>-        mColumnDescription = aString;
>+        mColumnDescription = NS_ConvertUCS2toUTF8(aString);
>     }

Maybe use CopyUTF16toUTF8 here instead?

>     void SetRowDescription(nsAString &aString) {
>-        mRowDescription = aString;
>+        mRowDescription = NS_ConvertUCS2toUTF8(aString);
>     }

Same.

Comment 3

[Louie Zhao]

Attachment: patch v2

Updated patch (using CopyUTF18toUTF8 instead of NS_ConvertUCS2toUTF8)

Comment 4

[Louie Zhao]

patch checked in