Closed
Bug 278546
Opened 20 years ago
Closed 20 years ago
Potential unchecked null pointer crash in nsPresShell::GetViewToScroll
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
()
Details
(Keywords: crash)
Attachments
(1 file)
|
1.35 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
You can't call svp->GetScrollableView()->View() because GetScrollableView can return null. I am unable to consistently reproduce the crash, although an assertion I added while writing a crash fix warns me from time to time.
|
Assignee | |
Comment 1•20 years ago
|
||
Assignee: nobody → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #171379 -
Flags: superreview?(bzbarsky)
Attachment #171379 -
Flags: review?(bzbarsky)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 171379 [details] [diff] [review] Proposed patch r+sr=bzbarsky, but should nsIScrollableViewProvider ever return null? If not, it may be worth adding an assert here and trying to find cases when it doesn't...
Attachment #171379 -
Flags: superreview?(bzbarsky)
Attachment #171379 -
Flags: superreview+
Attachment #171379 -
Flags: review?(bzbarsky)
Attachment #171379 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Severity: normal → critical
|
||
Comment 4•20 years ago
|
||
Does this mean bug 262578 can be reclosed now?
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•