279100 - JS error pressing ESC in Help window

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[[e-mail]]

This is a regression from bug 68348. Because the ESC key was moved from
navigatorOverlay.xul to platformNavigationBindings.xul which Help uses for the
back/forward keys, it now tries to call an undefined functionBrowserStop().

Comment 1

[Asaf Romano (gone)]

Attachment: patch v1

Comment 2

[[e-mail]]

Comment on attachment 174521 [details] [diff] [review]
patch v1

>     <command id="Browser:Home"    oncommand="BrowserHome(event);"/>
>     <command id="Browser:Back"    oncommand="BrowserBack();"    observes="canGoBack"/>
>     <command id="Browser:Forward" oncommand="BrowserForward();" observes="canGoForward"/>
>+    <command id="Browser:Stop" oncommand="BrowserStop();"/>
Make these line up please...


>-    <key id="key_stop" keycode="VK_ESCAPE" oncommand="BrowserStop();"/>
>+    <key id="key_stop" keycode="VK_ESCAPE" oncommand="Browser:Stop"/>
I think you forgot to change this one to command=

The problem with this patch is that someone might be tempted to hook the Stop
button and menuitems into this command. However disabling the command will
disable the key too, although hitting Escape on a loaded page serves to cancel
all timeouts. For comparison FireFox hooks the Stop button and menuitems into
the command, but not the Escape key.

Comment 3

[Asaf Romano (gone)]

Attachment: another approach

Comment 4

[[e-mail]]

Comment on attachment 174561 [details] [diff] [review]
another approach

The id of key_stop_mac is confusing, as its actual value is the normal stop key
on the other platforms! Maybe call it key_stop2?

Comment 5

[Asaf Romano (gone)]

(with the change to key_stop2)

Checking in xpfe/browser/resources/content/mac/platformNavigationBindings.xul;
/cvsroot/mozilla/xpfe/browser/resources/content/mac/platformNavigationBindings.xul,v
 <--  platformNavigationBindings.xul
new revision: 1.15; previous revision: 1.14
done
Checking in extensions/help/resources/content/help.xul;
/cvsroot/mozilla/extensions/help/resources/content/help.xul,v  <--  help.xul
new revision: 1.57; previous revision: 1.56
done