280200 - [patch] improve IME look and feel : IME color

Status: RESOLVED FIXED

(Camino Graveyard :: HTML Form Controls, defect)

Description

[waverider]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.6) Gecko/20041230 Camino/0.8.2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.6) Gecko/20041230 Camino/0.8.2

correct IME Constants selecting and improve IME look and feel.

Reproducible: Always

Steps to Reproduce:

Comment 1

[waverider]

Attachment: correct IME Constants selecting.

Comment 2

[Mike Pinkerton (not reading bugmail)]

+  if (selRange.length == 0)
+  {
+    switch (aUnderlineStyle) {
+      case 1:
+        return NS_TEXTRANGE_RAWINPUT;
+        break;
+        
+      case 2:
+        return NS_TEXTRANGE_SELECTEDRAWTEXT;
+        break;
+    }
+  }

don't use multiple returns here. use a single variable for the return value
(initialized appropriately) and set it in the switch statements, then return
that var at the end of the routine. Makes the flow much easier to follow.

Comment 3

[Jasper]

Shall I confirm this guys.

Comment 4

[waverider]

Attachment: Thank you advice. I rewrite a patch.

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 172798 [details] [diff] [review]
Thank you advice. I rewrite a patch.

attr could remain uninitialized if none of the case statements are hit. Either
initialize it or add default: statements.

Comment 6

[Simon Fraser [no longer active]]

Comment on attachment 172798 [details] [diff] [review]
Thank you advice. I rewrite a patch.

Sorry, I'm blind. The patch is fine. I'll test then check it in.

Comment 7

[Simon Fraser [no longer active]]

I checked in the patch (with minor tweaks). Thanks!