280231 - WINCE embedding changes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Doug Turner (:dougt)]

needed to make a few small build changes to get mozilla/content to compile on wince

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Benjamin Smedberg]

Comment on attachment 172716 [details] [diff] [review]
patch v.1

>Index: embedding/base/Makefile.in

>-ifeq ($(OS_ARCH),WINNT)
>+ifeq (,$(filter-out WINNT WINCE,$(OS_ARCH)))

"standard style" is "ifneq (,$(filter WINNT WINCE,$(OS_ARCH))"

>Index: embedding/browser/build/Makefile.in

ditto

>Index: embedding/components/build/Makefile.in

>+ifneq ($(OS_ARCH), WINCE)

Remove the extra space, which can cause problems.

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 172716 [details] [diff] [review]
patch v.1

Benjamin, both styles exist live in the tree and there isn't any documentation
which way is more correct, even though they are equal.	I would like to leave
these as is.

if that is a problem, we should probably make a single sweep through the tree
and kill all filter-out's.

Where

Comment 4

[Doug Turner (:dougt)]

Checking in embedding/base/Makefile.in;
/cvsroot/mozilla/embedding/base/Makefile.in,v  <--  Makefile.in
new revision: 1.32; previous revision: 1.31
done
Checking in embedding/base/nsEmbedAPI.h;
/cvsroot/mozilla/embedding/base/nsEmbedAPI.h,v  <--  nsEmbedAPI.h
new revision: 1.15; previous revision: 1.14
done
Checking in embedding/browser/build/Makefile.in;
/cvsroot/mozilla/embedding/browser/build/Makefile.in,v  <--  Makefile.in
new revision: 1.33; previous revision: 1.32
done
Checking in embedding/components/build/Makefile.in;
/cvsroot/mozilla/embedding/components/build/Makefile.in,v  <--  Makefile.in
new revision: 1.49; previous revision: 1.48
done


Thanks for the review!!