Closed
Bug 280731
Opened 20 years ago
Closed 20 years ago
nsIProtocolProxyService::NewProxyInfo is broken
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
VERIFIED
FIXED
mozilla1.8beta1
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
(Keywords: regression)
Attachments
(1 file)
|
1.13 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
nsIProtocolProxyService::NewProxyInfo is broken
The line:
"if (aType.LowerCaseEqualsASCII(types[i]) == 0) {"
is plainly wrong. This was introduced by carelessly translating code that used
PL_strcasecmp previously. My bad! :-(
Fortunately, this bug doesn't affect Firefox 1.0 or Mozilla 1.7.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #173136 -
Flags: superreview?(bzbarsky)
Attachment #173136 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta
|
||
Comment 2•20 years ago
|
||
Comment on attachment 173136 [details] [diff] [review] v1 patch r+sr=bzbarsky
Attachment #173136 -
Flags: superreview?(bzbarsky)
Attachment #173136 -
Flags: superreview+
Attachment #173136 -
Flags: review?(bzbarsky)
Attachment #173136 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
V/lxr. 1.61 darin%meer.net 2005-02-01 22:34 fixes bug 280731 "nsIProtocolProxyService::NewProxyInfo is broken" r+sr=bzbarsky
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•