Closed
Bug 281056
Opened 20 years ago
Closed 20 years ago
Build error when "disable-v1-string-abi" is applied
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sugar.waffle, Assigned: darin.moz)
Details
Attachments
(1 file)
|
4.99 KB,
patch
|
bryner
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
The errors occur when the "ac_add_options --disable-v1-string-abi" option is applied. Mac OS X 10.3.7 https://bugzilla.mozilla.org/show_bug.cgi?id=235499#c39
|
||
Comment 1•20 years ago
|
||
This broke with the checkin for bug 235499. nsA[C]StringAccessor and its callers should be #ifdef'd to not check the vtable if MOZ_V1_STRING_ABI is not defined.
Assignee: nobody → darin
|
Assignee | |
Comment 2•20 years ago
|
||
Attachment #173577 -
Flags: superreview?(bryner)
Attachment #173577 -
Flags: review?(bryner)
|
|
||
Updated•20 years ago
|
Attachment #173577 -
Flags: superreview?(bryner)
Attachment #173577 -
Flags: superreview+
Attachment #173577 -
Flags: review?(bryner)
Attachment #173577 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
fixed-on-trunk
Status: UNCONFIRMED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•20 years ago
|
||
I also enabled --disable-v1-string-abi on the neptune minimo tinderbox.
Summary: Build error when "--disable-v1-string-abi" is applied → Build error when "disable-v1-string-abi" is applied
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•