Closed Bug 281367 Opened 20 years ago Closed 20 years ago

Segfault when using cups with no default printer set [@ GlobalPrinters::InitializeGlobalPrinters]

Categories

(Core Graveyard :: GFX: Gtk, defect)

Product:
Core Graveyard
Component:
GFX: Gtk
Version:
1.7 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jfh, Assigned: blizzard)

References

Details

(Keywords: fixed-aviary1.0.1, fixed1.7.6)

Attachments

(2 files, 1 obsolete file)

Stack trace
4.76 KB, text/plain
Details
proposed patch
1.33 KB, patch
mkaply
: review+
dveditz
: approval-aviary1.0.1+
dveditz
: approval1.7.6+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041228 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041228 Firefox/1.0

When CUPS has no default printer set, and firefox/mozilla is using cups
to determine the printer list, thet crash due to a null pointer reference.

Reproducible: Always

Steps to Reproduce:
1. Start firefox
2. Select "Print..."
3.

Actual Results:  
Crash

Expected Results:  
Popped up the print dialog

Crash in /usr/local/lib/firefox-1.0/components/libgfx_gtk.so
Attached file Stack trace — 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        proposed patch (obsolete)
        — 
          — Splinter Review
      

    


  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        proposed patch
        — 
          — Splinter Review
      

    


  
Ack, I initially generated a reverse patch.

        Attachment #173618 -
        Attachment is obsolete: true

    
  
Assignee: firefox → blizzard
Component: General → GFX: Gtk
Product: Firefox → Core
QA Contact: general → ian
Version: unspecified → 1.7 Branch

    
    

    
  
James, you want to request reviews for patches... See
http://www.mozilla.org/hacking/life-cycle.html

That said, the code you're patching seems to be gone (removed in Sept by the fix
for bug 257381).  Is this still an issue in trunk builds?

    
    

    
  
This is affecting the aviary and mozilla 1.7 branches; see bug 278420. It's the
source of a lot of talkback reports, and if there are any further releases from
those branches it'd be nice to fix this.

    
    

    
  
Comment on attachment 173619 [details] [diff] [review]
proposed patch

r=mkaply

Let's get this in for the branches.

        Attachment #173619 -
        Flags: review+

        Attachment #173619 -
        Flags: approval1.7.6?

        Attachment #173619 -
        Flags: approval-aviary1.0.1?

    
  
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: 278420

    
    

    
  
*** Bug 278420 has been marked as a duplicate of this bug. ***
Summary: Segfault in GlobalPrinters::InitializeGlobalPrinters (nsDeviceContextSpecG.cpp) when using cups with no default printer set → Segfault when using cups with no default printer set [@ GlobalPrinters::InitializeGlobalPrinters]

    
    

    
  
Comment on attachment 173619 [details] [diff] [review]
proposed patch

a=dveditz for the branches IIF landed today.

        Attachment #173619 -
        Flags: approval1.7.6?

        Attachment #173619 -
        Flags: approval1.7.6+

        Attachment #173619 -
        Flags: approval-aviary1.0.1?

        Attachment #173619 -
        Flags: approval-aviary1.0.1+

    
    

    
  
checked in. thank you very much for the patch.
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0.1, 
          
            fixed1.7.6
Resolution: --- → FIXED

    
    

    
  
*** Bug 260675 has been marked as a duplicate of this bug. ***
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: