281742 - text as clip path causes paint loop

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

In the process of drawing the clip region, we invalidate the CTM of the
the glyph frame.  Normally this invalidates the region covered by the
text, but since we're already drawing we get into a paint loop.  Stop
this happening in the same manner done by nsSVGPathGeometryFrame.

Comment 1

[tor]

Attachment: stop paint loop

Comment 2

[Scooter Morris]

Comment on attachment 173909 [details] [diff] [review]
stop paint loop

>Index: nsSVGGlyphFrame.cpp
>===================================================================
nit: weill --> will??

>+    if (dirty_region) {
>+      // if we're being used as a clippath, this weill get called
>+      // during the paint - don't need to invalidate (which causes
>+      // us to loop busy-painting)
>+
>+      nsIView *view = GetClosestView();
>+      if (!view) return;
>+      nsIViewManager *vm = view->GetViewManager();
>+      PRBool painting;
>+      vm->IsPainting(painting);

Comment 3

[tor]

Nit fixed, checked in.