282819 - use NS_ConvertASCIItoUTF16(aString, aLength) instead of the manual expansion in nsFontMetricsGTK/Xlib

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect)

Description

[Jungshik Shin]

nsFontMetricsGTK and nsFontMetricsXlib use the following pattern in several places.
        // need to fix this for long strings
        PRUint32 len = PR_MIN(aLength, WIDEN_8_TO_16_BUF_SIZE);

        // convert 7 bit data to unicode
        // this function is only supposed to be called for ascii data
        for (PRUint32 i=0; i<len; i++) {
            unichars[i] = (PRUnichar)((unsigned char)aString[i]);
        }

We can get rid of them using NS_ConvertASCIItoUTF16(aString, aLength)

Comment 1

[Jungshik Shin]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 174789 [details] [diff] [review]
patch

sr=dbaron assuming the TryNode/TryNodes change was not supposed to be included
in this patch

Comment 3

[Jungshik Shin]

Comment on attachment 174789 [details] [diff] [review]
patch

Simon should be as good as Roland for this.

Comment 4

[Simon Montagu :smontagu]

Comment on attachment 174789 [details] [diff] [review]
patch

Gee, I almost lost this among today's bugspam.

r=smontagu, but you might want to retain the comments
// this function is only supposed to be called for ascii data

Comment 5

[Jungshik Shin]

Thankss for review. I added back the comment when landing.