282871 - default X11 build should be GTK2 instead of GTK1

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

As bsmedberg suggested in bug 281402 comment 2 (and I agree), we should change
the default toolkit for X11-based platforms from GTK1 to GTK2.  The simplest way
to do this is just to change the line in configure.in from
_PLATFORM_DEFAULT_TOOLKIT=gtk
to
_PLATFORM_DEFAULT_TOOLKIT=gtk2

However, bsmedberg suggests we may want some kind of runtime check where we
default to gtk2 if it is present and gtk1 otherwise.  I actually think this is a
bad idea -- I prefer builds being reproducable given a set of options.  It would
also make the patch more complicated.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note that if we did this we'd need to reconfigure a bunch of tinderbox / build
machines first (although actually not that many).

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

isn't this a duplicate of bug 270750?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

No (as far as I can tell), since that's about what we ship, not about what the
build system does by default.

Comment 4

[Christopher Blizzard (:blizzard)]

Yeah, it's time for this to change.  Welcome to the year 2005.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: the simple approach

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk, 2005-03-29 17:17 -0800.